From: Linus Walleij <linus.walleij@linaro.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Michal Miroslaw <mirq-linux@rere.qmqm.pl>,
Florian Fainelli <f.fainelli@gmail.com>,
Paulius Zaleckas <paulius.zaleckas@gmail.com>,
Hans Ulli Kroll <ulli.kroll@googlemail.com>,
Janos Laube <janos.dev@gmail.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH net-next 5/5 v2] net: gemini: Indicate that we can handle jumboframes
Date: Wed, 11 Jul 2018 21:10:21 +0200 [thread overview]
Message-ID: <CACRpkdbaPqqGEag94k5AnMJ8Bq7cjfET_gQsEfoxM=72_U34yg@mail.gmail.com> (raw)
In-Reply-To: <20180704203556.GC23469@lunn.ch>
On Wed, Jul 4, 2018 at 10:35 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Wed, Jul 04, 2018 at 08:33:24PM +0200, Linus Walleij wrote:
> > The hardware supposedly handles frames up to 10236 bytes and
> > implements .ndo_change_mtu() so accept 10236 minus the ethernet
> > header for a VLAN tagged frame on the netdevices. Use
> > ETH_MIN_MTU as minimum MTU.
> >
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> Hi Linus
>
> Did you try with an MTU of 68? Maybe the vendor picked 256 because of
> a hardware limit?
Yeah works fine:
ping -s 68 169.254.1.2
PING 169.254.1.2 (169.254.1.2) 68(96) bytes of data.
76 bytes from 169.254.1.2: icmp_seq=1 ttl=64 time=0.359 ms
76 bytes from 169.254.1.2: icmp_seq=2 ttl=64 time=0.346 ms
76 bytes from 169.254.1.2: icmp_seq=3 ttl=64 time=0.351 ms
This also works fine:
ping -s 9000 169.254.1.2
PING 169.254.1.2 (169.254.1.2) 9000(9028) bytes of data.
9008 bytes from 169.254.1.2: icmp_seq=1 ttl=64 time=1.45 ms
9008 bytes from 169.254.1.2: icmp_seq=2 ttl=64 time=1.68 ms
9008 bytes from 169.254.1.2: icmp_seq=3 ttl=64 time=1.55 ms
I'll send new patches with all suggested changes soon :)
Thanks a lot for your help!
Yours,
Linus Walleij
next prev parent reply other threads:[~2018-07-11 19:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 18:33 [PATCH net-next 1/5 v2] net: gemini: Look up L3 maxlen from table Linus Walleij
2018-07-04 18:33 ` [PATCH net-next 2/5 v2] net: gemini: Improve connection prints Linus Walleij
2018-07-04 20:40 ` Andrew Lunn
2018-07-08 20:47 ` Linus Walleij
2018-07-04 18:33 ` [PATCH net-next 3/5 v2] net: gemini: Allow multiple ports to instantiate Linus Walleij
2018-07-04 18:33 ` [PATCH net-next 4/5 v2] net: gemini: Move main init to port Linus Walleij
2018-07-04 18:33 ` [PATCH net-next 5/5 v2] net: gemini: Indicate that we can handle jumboframes Linus Walleij
2018-07-04 20:35 ` Andrew Lunn
2018-07-11 19:10 ` Linus Walleij [this message]
2018-07-07 16:14 ` [PATCH net-next 1/5 v2] net: gemini: Look up L3 maxlen from table Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbaPqqGEag94k5AnMJ8Bq7cjfET_gQsEfoxM=72_U34yg@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=janos.dev@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=paulius.zaleckas@gmail.com \
--cc=ulli.kroll@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).