From: Soheil Hassas Yeganeh <soheil@google.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Neal Cardwell <ncardwell@google.com>,
Yuchung Cheng <ycheng@google.com>, Wei Wang <weiwan@google.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] tcp: fix tcp_rearm_rto()
Date: Thu, 18 May 2017 12:55:49 -0400 [thread overview]
Message-ID: <CACSApvZ6ohkO7tvU65SCFHy2FWoMppKaPST-3nWMimSruQO16w@mail.gmail.com> (raw)
In-Reply-To: <1495124158.6465.30.camel@edumazet-glaptop3.roam.corp.google.com>
On Thu, May 18, 2017 at 12:15 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> skbs in (re)transmit queue no longer have a copy of jiffies
> at the time of the transmit : skb->skb_mstamp is now in usec unit,
> with no correlation to tcp_jiffies32.
>
> We have to convert rto from jiffies to usec, compute a time difference
> in usec, then convert the delta to HZ units.
>
> Fixes: 9a568de4818d ("tcp: switch TCP TS option (RFC 7323) to 1ms clock")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Soheil Hassas Yeganeh <soheil@google.com>
Thank you for the quick fix, Eric!
next prev parent reply other threads:[~2017-05-18 16:56 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 20:59 [PATCH net-next 00/15] tcp: TCP TS option use 1 ms clock Eric Dumazet
2017-05-16 21:00 ` [PATCH net-next 01/15] tcp: use tp->tcp_mstamp in output path Eric Dumazet
2017-05-17 13:42 ` Soheil Hassas Yeganeh
2017-05-16 21:00 ` [PATCH net-next 02/15] tcp: introduce tcp_jiffies32 Eric Dumazet
2017-05-17 13:43 ` Soheil Hassas Yeganeh
2017-05-16 21:00 ` [PATCH net-next 03/15] dccp: do not use tcp_time_stamp Eric Dumazet
2017-05-17 13:43 ` Soheil Hassas Yeganeh
2017-05-16 21:00 ` [PATCH net-next 04/15] tcp: use tcp_jiffies32 to feed tp->lsndtime Eric Dumazet
2017-05-17 13:43 ` Soheil Hassas Yeganeh
2017-05-16 21:00 ` [PATCH net-next 05/15] tcp: use tcp_jiffies32 to feed tp->snd_cwnd_stamp Eric Dumazet
2017-05-17 13:45 ` Soheil Hassas Yeganeh
2017-05-16 21:00 ` [PATCH net-next 06/15] tcp_bbr: use tcp_jiffies32 instead of tcp_time_stamp Eric Dumazet
2017-05-17 13:45 ` Soheil Hassas Yeganeh
2017-05-16 21:00 ` [PATCH net-next 07/15] tcp: bic,cubic: " Eric Dumazet
2017-05-17 13:46 ` Soheil Hassas Yeganeh
2017-05-16 21:00 ` [PATCH net-next 08/15] tcp: use tcp_jiffies32 for rcv_tstamp and lrcvtime Eric Dumazet
2017-05-17 13:46 ` Soheil Hassas Yeganeh
2017-05-16 21:00 ` [PATCH net-next 09/15] tcp: use tcp_jiffies32 to feed probe_timestamp Eric Dumazet
2017-05-17 13:46 ` Soheil Hassas Yeganeh
2017-05-16 21:00 ` [PATCH net-next 10/15] tcp: uses jiffies_32 to feed tp->chrono_start Eric Dumazet
2017-05-17 13:46 ` Soheil Hassas Yeganeh
2017-05-16 21:00 ` [PATCH net-next 11/15] tcp: use tcp_jiffies32 in __tcp_oow_rate_limited() Eric Dumazet
2017-05-17 13:47 ` Soheil Hassas Yeganeh
2017-05-16 21:00 ` [PATCH net-next 12/15] tcp_westwood: use tcp_jiffies32 instead of tcp_time_stamp Eric Dumazet
2017-05-17 13:47 ` Soheil Hassas Yeganeh
2017-05-16 21:00 ` [PATCH net-next 13/15] tcp_lp: cache tcp_time_stamp Eric Dumazet
2017-05-17 13:47 ` Soheil Hassas Yeganeh
2017-05-16 21:00 ` [PATCH net-next 14/15] tcp: replace misc tcp_time_stamp to tcp_jiffies32 Eric Dumazet
2017-05-17 13:47 ` Soheil Hassas Yeganeh
2017-05-16 21:00 ` [PATCH net-next 15/15] tcp: switch TCP TS option (RFC 7323) to 1ms clock Eric Dumazet
2017-05-17 13:51 ` Soheil Hassas Yeganeh
2017-05-18 12:33 ` Eric Dumazet
2017-05-18 16:15 ` [PATCH net-next] tcp: fix tcp_rearm_rto() Eric Dumazet
2017-05-18 16:55 ` Soheil Hassas Yeganeh [this message]
2017-05-18 17:20 ` David Miller
2017-05-17 20:06 ` [PATCH net-next 00/15] tcp: TCP TS option use 1 ms clock David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACSApvZ6ohkO7tvU65SCFHy2FWoMppKaPST-3nWMimSruQO16w@mail.gmail.com \
--to=soheil@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=weiwan@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).