From: Soheil Hassas Yeganeh <soheil.kdev@gmail.com>
To: Eric Dumazet <edumazet@google.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Neal Cardwell <ncardwell@google.com>,
Yuchung Cheng <ycheng@google.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net-next 0/2] tcp_bbr: more GSO work
Date: Wed, 28 Feb 2018 22:42:04 +0000 [thread overview]
Message-ID: <CACSApvZGDh3n7rToZRf1AOH3pd-WfA-bN4pULzOcTr8k5fLjpQ@mail.gmail.com> (raw)
In-Reply-To: <20180228224047.123054-1-edumazet@google.com>
On Wed, Feb 28, 2018 at 5:40 PM Eric Dumazet <edumazet@google.com> wrote:
> Playing with r8152 USB 1Gbit NIC, on both USB2 and USB3 slots,
> I found that BBR was performing poorly, because of TSO being limited to
16KB
> This patch series makes sure BBR is not under estimating number
> of packets that are needed to fill the pipe when a device has
> suboptimal TSO limits.
> Eric Dumazet (2):
> tcp_bbr: better deal with suboptimal GSO (II)
> tcp_bbr: remove bbr->tso_segs_goal
Acked-by: Soheil Hassas Yeganeh <soheil@google.com>
Thank you, Eric!
> include/net/tcp.h | 6 ++----
> net/ipv4/tcp_bbr.c | 33 ++++++++++++++++-----------------
> net/ipv4/tcp_output.c | 15 ++++++++-------
> 3 files changed, 26 insertions(+), 28 deletions(-)
> --
> 2.16.2.395.g2e18187dfd-goog
next prev parent reply other threads:[~2018-02-28 22:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 22:40 [PATCH net-next 0/2] tcp_bbr: more GSO work Eric Dumazet
2018-02-28 22:40 ` [PATCH net-next 1/2] tcp_bbr: better deal with suboptimal GSO (II) Eric Dumazet
2018-03-01 3:15 ` Neal Cardwell
2018-02-28 22:40 ` [PATCH net-next 2/2] tcp_bbr: remove bbr->tso_segs_goal Eric Dumazet
2018-03-01 3:17 ` Neal Cardwell
2018-02-28 22:42 ` Soheil Hassas Yeganeh [this message]
2018-03-02 2:44 ` [PATCH net-next 0/2] tcp_bbr: more GSO work David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACSApvZGDh3n7rToZRf1AOH3pd-WfA-bN4pULzOcTr8k5fLjpQ@mail.gmail.com \
--to=soheil.kdev@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).