From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f65.google.com ([209.85.214.65]:39451 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935428AbeB1Wmn (ORCPT ); Wed, 28 Feb 2018 17:42:43 -0500 Received: by mail-it0-f65.google.com with SMTP id l187so5511678ith.4 for ; Wed, 28 Feb 2018 14:42:42 -0800 (PST) Received: from mail-io0-f176.google.com (mail-io0-f176.google.com. [209.85.223.176]) by smtp.gmail.com with ESMTPSA id k76sm2265510ita.32.2018.02.28.14.42.41 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Feb 2018 14:42:41 -0800 (PST) Received: by mail-io0-f176.google.com with SMTP id e7so5036160ioj.1 for ; Wed, 28 Feb 2018 14:42:41 -0800 (PST) MIME-Version: 1.0 References: <20180228224047.123054-1-edumazet@google.com> In-Reply-To: <20180228224047.123054-1-edumazet@google.com> From: Soheil Hassas Yeganeh Date: Wed, 28 Feb 2018 22:42:04 +0000 Message-ID: Subject: Re: [PATCH net-next 0/2] tcp_bbr: more GSO work To: Eric Dumazet Cc: David Miller , netdev , Neal Cardwell , Yuchung Cheng , Eric Dumazet Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Feb 28, 2018 at 5:40 PM Eric Dumazet wrote: > Playing with r8152 USB 1Gbit NIC, on both USB2 and USB3 slots, > I found that BBR was performing poorly, because of TSO being limited to 16KB > This patch series makes sure BBR is not under estimating number > of packets that are needed to fill the pipe when a device has > suboptimal TSO limits. > Eric Dumazet (2): > tcp_bbr: better deal with suboptimal GSO (II) > tcp_bbr: remove bbr->tso_segs_goal Acked-by: Soheil Hassas Yeganeh Thank you, Eric! > include/net/tcp.h | 6 ++---- > net/ipv4/tcp_bbr.c | 33 ++++++++++++++++----------------- > net/ipv4/tcp_output.c | 15 ++++++++------- > 3 files changed, 26 insertions(+), 28 deletions(-) > -- > 2.16.2.395.g2e18187dfd-goog