From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E2A0C43381 for ; Fri, 29 Mar 2019 19:50:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 614692184C for ; Fri, 29 Mar 2019 19:50:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hrZ7Y80n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730006AbfC2Tuz (ORCPT ); Fri, 29 Mar 2019 15:50:55 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:35340 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729983AbfC2Tuz (ORCPT ); Fri, 29 Mar 2019 15:50:55 -0400 Received: by mail-wr1-f67.google.com with SMTP id w1so4012547wrp.2 for ; Fri, 29 Mar 2019 12:50:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nOhq/wkgP+Ax8LO1CIgmzzsti3W0qVBH7zZl7MRKM7A=; b=hrZ7Y80n4+kIdZMiRHikEqGFk6cAY++izaEfm7PG71P4dVl51Wr6akxy1sUP+OmGog gtYNrAeY2y/pZDRr3mXdT5OawOZkS8eGQf+TqL5kqmfhOpRlrNEvLtsrtXITWeGdDUeu myD5l2D/BkqqkL4W81/dlX7d4WuJJRsKlfIiMy4RHrrZ6Mb72rCRC1CPG7dYizNGVc7N DJYFLQm8qeV28mRXFhaE1p8sKkd4UWY/GxdgFcM0rg28H3ZxGAD5blVZZv32KveYUFmg Yfd1VN+T3QPZdLxy/0JdAbltlY6ZI2EDHCyPvjTczs1sVSl9gmc97921Tj4gC5Mgljbx 8rmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nOhq/wkgP+Ax8LO1CIgmzzsti3W0qVBH7zZl7MRKM7A=; b=tJc4A/3z2bdgHkGYJJTroJxaXhyq3wIvdPz+n8v3RSBqbh7tyUn3HbD+uG3ZIk2Txk meRgOEm1GtupGl1o6LjnZU778hj+4yWqMRQ2FjYgn/VUC+bgKN2Va+WtegXq103snb/Q kKGWvqRHDOn1MnIVFyWkJKY99zmAoDXZIND1vB6aJA5TeN+8tFij1Up0slES8WFhMhMC gWRZMsxoqKWJVjxySaD73L6uv7eJGI8ZGkvbgiwr4+6K/YqYTWl5rSQlzZd6WYy5oBVf oTmxZyyaO4XllipOV/CoNo+7LQdX07ORdzPz840UBgDaVB9kwYl9XQozYGfsVxs2qLsh AXbQ== X-Gm-Message-State: APjAAAUCAPiOKxdDL9PJaHfUdJXA68rVNpTKXp/8Z5dLRojpV3fjiuR2 AWM8efjk9gHSGP5cZfsJqOSXrsCzmovwxc+a3IO3Tw== X-Google-Smtp-Source: APXvYqxtOcyqvNS4V19izXFKT1WOqt5q0CKeXTzKtxghcDnKsKEzJfGTJnVMmrOl/+vIc0y6txMfbRRqaiqMjTp3AaQ= X-Received: by 2002:adf:eb85:: with SMTP id t5mr32628249wrn.168.1553889052672; Fri, 29 Mar 2019 12:50:52 -0700 (PDT) MIME-Version: 1.0 References: <20190329194617.195528-1-edumazet@google.com> In-Reply-To: <20190329194617.195528-1-edumazet@google.com> From: Soheil Hassas Yeganeh Date: Fri, 29 Mar 2019 15:50:16 -0400 Message-ID: Subject: Re: [PATCH net-next] tcp: cleanup sk_tx_skb_cache before reuse To: Eric Dumazet Cc: "David S . Miller" , netdev , Eric Dumazet , Willem de Bruijn Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Mar 29, 2019 at 3:46 PM Eric Dumazet wrote: > > TCP stack relies on the fact that a freshly allocated skb > has skb->cb[] and skb_shinfo(skb)->tx_flags cleared. > > When recycling tx skb, we must ensure these fields are cleared. > > Fixes: 472c2e07eef0 ("tcp: add one skb cache for tx") > Signed-off-by: Eric Dumazet > Cc: Soheil Hassas Yeganeh > Cc: Willem de Bruijn Acked-by: Soheil Hassas Yeganeh Nice catch! Thank you! > --- > net/ipv4/tcp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c > index 82bd707c03472f2cebb1a90d5f1c13acc821468f..603e770d59b3db96adca9602319d2f6970a56285 100644 > --- a/net/ipv4/tcp.c > +++ b/net/ipv4/tcp.c > @@ -872,6 +872,8 @@ struct sk_buff *sk_stream_alloc_skb(struct sock *sk, int size, gfp_t gfp, > sk->sk_tx_skb_cache = NULL; > pskb_trim(skb, 0); > INIT_LIST_HEAD(&skb->tcp_tsorted_anchor); > + skb_shinfo(skb)->tx_flags = 0; > + memset(TCP_SKB_CB(skb), 0, sizeof(struct tcp_skb_cb)); > return skb; > } > } > -- > 2.21.0.392.gf8f6787159e-goog >