From: Dmitry Vyukov <dvyukov@google.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Cong Wang <xiyou.wangcong@gmail.com>,
netdev <netdev@vger.kernel.org>,
syzkaller <syzkaller@googlegroups.com>
Subject: Re: net: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detected in skb_array_produce
Date: Thu, 9 Feb 2017 18:55:41 +0100 [thread overview]
Message-ID: <CACT4Y+a-SXFy1nu+9CKmn3-sR1t5c531TFwt3Ruf4F88p7AXqw@mail.gmail.com> (raw)
In-Reply-To: <20170209194943-mutt-send-email-mst@kernel.org>
On Thu, Feb 9, 2017 at 6:50 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Thu, Feb 09, 2017 at 11:49:30AM +0100, Dmitry Vyukov wrote:
>> On Thu, Feb 9, 2017 at 11:02 AM, Jason Wang <jasowang@redhat.com> wrote:
>> >
>> >
>> > ----- Original Message -----
>> >> Hello,
>> >>
>> >> I've got the following report while running syzkaller fuzzer on mmotm
>> >> (git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git)
>> >> remotes/mmotm/auto-latest ee4ba7533626ba7bf2f8b992266467ac9fdc045e:
>> >>
>> >
>> > [...]
>> >
>> >>
>> >> other info that might help us debug this:
>> >>
>> >> Possible interrupt unsafe locking scenario:
>> >>
>> >> CPU0 CPU1
>> >> ---- ----
>> >> lock(&(&r->consumer_lock)->rlock);
>> >> local_irq_disable();
>> >> lock(&(&r->producer_lock)->rlock);
>> >> lock(&(&r->consumer_lock)->rlock);
>> >> <Interrupt>
>> >> lock(&(&r->producer_lock)->rlock);
>> >>
>> >
>> > Thanks a lot for the testing.
>> >
>> > Looks like we could address this by using skb_array_consume_bh() instead.
>> >
>> > Could you pls verify if the following patch works?
>>
>> No, I can't test it, sorry. This happened once on bots. And bots
>> currently test only upstream versions.
>
> Which trees are tested? Will linux-next help?
Linus tree, linux-next and mmotm at the moment.
next prev parent reply other threads:[~2017-02-09 17:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 8:38 net: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detected in skb_array_produce Dmitry Vyukov
2017-02-09 10:02 ` Jason Wang
2017-02-09 10:49 ` Dmitry Vyukov
2017-02-09 17:50 ` Michael S. Tsirkin
2017-02-09 17:55 ` Dmitry Vyukov [this message]
2017-02-09 18:10 ` Michael S. Tsirkin
2017-02-10 5:13 ` Jason Wang
2017-02-09 18:10 ` Michael S. Tsirkin
2017-02-10 5:17 ` Jason Wang
2017-02-18 17:28 ` Dmitry Vyukov
2017-02-18 17:35 ` Dmitry Vyukov
2017-02-19 5:18 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACT4Y+a-SXFy1nu+9CKmn3-sR1t5c531TFwt3Ruf4F88p7AXqw@mail.gmail.com \
--to=dvyukov@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).