From: Ming Lei <ming.lei@canonical.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: "Bjørn Mork" <bjorn@mork.no>,
"David S. Miller" <davem@davemloft.net>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
"Oliver Neukum" <oneukum@suse.de>,
"Alan Stern" <stern@rowland.harvard.edu>,
netdev@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v1] net/core: support runtime PM on net_device
Date: Fri, 19 Oct 2012 09:45:04 +0800 [thread overview]
Message-ID: <CACVXFVNXFEg0kiFb6RGfS9grYvyuRL-=jiqEdxDEnn0Avwpw9Q@mail.gmail.com> (raw)
In-Reply-To: <50802F8A.6090205@linaro.org>
On Fri, Oct 19, 2012 at 12:34 AM, Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
> Hi Ming,
>
> IIUC, the pm_runtime is related to the device drivers, so at the first
> glance, we should see invocation of the runtime's functions in drivers/*
> and arch/*. Adding these calls in the net core, which makes sense at a
> certain point, is a bit weird for me.
>
> From my POV, if the drivers have been modified to support the pm_runtime
> and this new functionality brought a regression with the ioctl, that
> should be fixed in the drivers and not in the core code.
>
> What happens with your patch if we use ethtool on a virtual device like
> veth, macvlan, bridge, ... ?
No any effect no matter if these drivers implement runtime PM or not.
Thanks,
--
Ming Lei
next prev parent reply other threads:[~2012-10-19 1:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 8:21 [PATCH v1] net/core: support runtime PM on net_device Ming Lei
2012-10-18 8:29 ` Bjørn Mork
2012-10-18 11:01 ` Ming Lei
2012-10-18 11:40 ` Bjørn Mork
2012-10-18 12:55 ` Ming Lei
2012-10-18 16:34 ` Daniel Lezcano
2012-10-19 1:45 ` Ming Lei [this message]
2012-10-18 19:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACVXFVNXFEg0kiFb6RGfS9grYvyuRL-=jiqEdxDEnn0Avwpw9Q@mail.gmail.com' \
--to=ming.lei@canonical.com \
--cc=bjorn@mork.no \
--cc=daniel.lezcano@linaro.org \
--cc=davem@davemloft.net \
--cc=linux-pm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).