From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ming Lei Subject: Re: [PATCH 4/7] usbnet: remove EVENT_DEV_OPEN flag Date: Wed, 13 Jun 2012 10:12:28 +0800 Message-ID: References: <1339463985-9006-1-git-send-email-tom.leiming@gmail.com> <1339463985-9006-5-git-send-email-tom.leiming@gmail.com> <201206122014.28408.oliver@neukum.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: "David S. Miller" , Greg Kroah-Hartman , netdev@vger.kernel.org, linux-usb@vger.kernel.org To: Oliver Neukum Return-path: Received: from mail-ob0-f174.google.com ([209.85.214.174]:61434 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752081Ab2FMCM2 (ORCPT ); Tue, 12 Jun 2012 22:12:28 -0400 In-Reply-To: <201206122014.28408.oliver@neukum.org> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Jun 13, 2012 at 2:14 AM, Oliver Neukum wrote: > Am Dienstag, 12. Juni 2012, 03:19:42 schrieb Ming Lei: >> EVENT_DEV_OPEN is introduced to mark if the interface is opened or >> not, but we already have IFF_UP to handle it, so just >> remove the flag and use IFF_UP. > > When is IFF_UP cleared? The flag is tested in usbnet_resume(), The flag is cleared just after usbnet_stop completes. > so it must be cleared before usbnet_stop() is called. Yes, I see, otherwise system or runtime resume may happen at the same time with usbnet_stop. Thanking you for point it out. Thanks, -- Ming Lei