From: Ming Lei <ming.lei@canonical.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: "David S. Miller" <davem@davemloft.net>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Oliver Neukum <oneukum@suse.de>,
Alan Stern <stern@rowland.harvard.edu>,
netdev@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v1] net/core: support runtime PM on net_device
Date: Thu, 18 Oct 2012 19:01:06 +0800 [thread overview]
Message-ID: <CACVXFVPu1m3CJaFavW9eaU3Z850q+x1N_Yo7tri1UTFpgfYVXQ@mail.gmail.com> (raw)
In-Reply-To: <8762689o9u.fsf@nemi.mork.no>
On Thu, Oct 18, 2012 at 4:29 PM, Bjørn Mork <bjorn@mork.no> wrote:
> Ming Lei <ming.lei@canonical.com> writes:
>
>> In ioctl path on net_device, the physical deivce is often
>> touched, but the physical device may have been put into runtime
>> suspend state already, so cause some utilitis(ifconfig, ethtool,
>> ...) to return failure in this situation.
>
> I have to as the stupid questions again, sorry...
>
> Just wondering, isn't that really a driver problem? The driver will
It is or not, :-)
> know whether or not hardware access is required, and should wake up the
The netcore knows that first, doesn't it?
> device if necessary. Unless I misunderstand something here, this seems
> like papering over driver bugs?
Suppose it is driver bug, and basically most network drivers don't consider
that, and we can fix that in netcore generally, so why bother all drivers to do
that?
Thanks,
--
Ming Lei
next prev parent reply other threads:[~2012-10-18 11:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 8:21 [PATCH v1] net/core: support runtime PM on net_device Ming Lei
2012-10-18 8:29 ` Bjørn Mork
2012-10-18 11:01 ` Ming Lei [this message]
2012-10-18 11:40 ` Bjørn Mork
2012-10-18 12:55 ` Ming Lei
2012-10-18 16:34 ` Daniel Lezcano
2012-10-19 1:45 ` Ming Lei
2012-10-18 19:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACVXFVPu1m3CJaFavW9eaU3Z850q+x1N_Yo7tri1UTFpgfYVXQ@mail.gmail.com \
--to=ming.lei@canonical.com \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=linux-pm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).