From: Feiyang Chen <chris.chenfeiyang@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Feiyang Chen <chenfeiyang@loongson.cn>,
hkallweit1@gmail.com, peppe.cavallaro@st.com,
alexandre.torgue@foss.st.com, joabreu@synopsys.com,
chenhuacai@loongson.cn, linux@armlinux.org.uk,
dongbiao@loongson.cn, loongson-kernel@lists.loongnix.cn,
netdev@vger.kernel.org, loongarch@lists.linux.dev
Subject: Re: [PATCH v2 05/10] net: stmmac: dwmac1000: Add Loongson register definitions
Date: Mon, 31 Jul 2023 17:39:45 +0800 [thread overview]
Message-ID: <CACWXhK=Dt1WW=7HmgsYVXVB4SCB3_Cu4sUYQtC-0CWdjB7wj4A@mail.gmail.com> (raw)
In-Reply-To: <64ebd141-87ee-4186-9b4d-0705402c9e89@lunn.ch>
On Fri, Jul 28, 2023 at 4:44 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Fri, Jul 28, 2023 at 09:45:42AM +0800, Feiyang Chen wrote:
> > On Thu, Jul 27, 2023 at 5:13 PM Andrew Lunn <andrew@lunn.ch> wrote:
> > >
> > > > /* GMAC HW ADDR regs */
> > > > -#define GMAC_ADDR_HIGH(reg) ((reg > 15) ? 0x00000800 + (reg - 16) * 8 : \
> > > > +#define GMAC_ADDR_HIGH(reg, x) ((reg > 15) ? 0x00000800 + (reg - 16) * 8 * (x) : \
> > > > 0x00000040 + (reg * 8))
> > >
> > > please give x a more descriptive name.
> > >
> >
> > Hi, Andrew,
> >
> > The x is now related to the dwmac_is_loongson flag. I'll try to use
> > another method.
>
> Rather than 'dwmac_is_longson', make it represent a feature of the
> MAC.
>
Hi, Andrew,
OK.
Thanks,
Feiyang
> Andrew
next prev parent reply other threads:[~2023-07-31 9:40 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 7:15 [PATCH v2 00/10] stmmac: Add Loongson platform support Feiyang Chen
2023-07-27 7:15 ` [PATCH v2 01/10] net: stmmac: Pass stmmac_priv and chan in some callbacks Feiyang Chen
2023-07-27 7:15 ` [PATCH v2 03/10] net: stmmac: dwmac1000: Add multi-channel support Feiyang Chen
2023-07-27 9:01 ` Andrew Lunn
2023-07-28 1:51 ` Feiyang Chen
2023-07-27 10:31 ` kernel test robot
2023-07-27 16:35 ` kernel test robot
2023-07-27 7:15 ` [PATCH v2 04/10] net: stmmac: dwmac1000: Add 64-bit DMA support Feiyang Chen
2023-07-27 9:06 ` Andrew Lunn
2023-07-28 1:40 ` Feiyang Chen
2023-07-27 7:18 ` [PATCH v2 02/10] net: stmmac: dwmac1000: Allow platforms to choose some register offsets Feiyang Chen
2023-07-27 9:10 ` Andrew Lunn
2023-07-28 1:41 ` Feiyang Chen
2023-07-27 7:18 ` [PATCH v2 05/10] net: stmmac: dwmac1000: Add Loongson register definitions Feiyang Chen
2023-07-27 9:13 ` Andrew Lunn
2023-07-28 1:45 ` Feiyang Chen
2023-07-28 8:44 ` Andrew Lunn
2023-07-31 9:39 ` Feiyang Chen [this message]
2023-07-27 7:18 ` [PATCH v2 06/10] net: stmmac: Add Loongson HWIF entry Feiyang Chen
2023-07-28 6:36 ` Ravi Gunasekaran
2023-07-31 9:44 ` Feiyang Chen
2023-07-28 9:24 ` Russell King (Oracle)
2023-07-31 9:46 ` Feiyang Chen
2023-07-31 15:16 ` Russell King (Oracle)
2023-08-03 1:33 ` Feiyang Chen
2023-07-27 7:18 ` [PATCH v2 07/10] net: stmmac: dwmac-loongson: Add LS7A support Feiyang Chen
2023-07-27 9:18 ` Andrew Lunn
2023-07-28 1:59 ` Feiyang Chen
2023-07-28 8:46 ` Andrew Lunn
2023-07-31 9:42 ` Feiyang Chen
2023-07-27 10:35 ` Andrew Lunn
2023-07-28 2:00 ` Feiyang Chen
2023-07-27 7:18 ` [PATCH v2 08/10] net: stmmac: dwmac-loongson: Disable flow control for GMAC Feiyang Chen
2023-07-27 10:36 ` Andrew Lunn
2023-07-28 1:46 ` Feiyang Chen
2023-07-27 7:18 ` [PATCH v2 09/10] net: stmmac: dwmac-loongson: Add 64-bit DMA and multi-vector support Feiyang Chen
2023-07-27 10:37 ` Andrew Lunn
2023-07-28 1:47 ` Feiyang Chen
2023-07-27 7:18 ` [PATCH v2 10/10] net: stmmac: dwmac-loongson: Add GNET support Feiyang Chen
2023-07-27 10:43 ` Andrew Lunn
2023-07-28 1:47 ` Feiyang Chen
2023-07-27 9:02 ` [PATCH v2 00/10] stmmac: Add Loongson platform support Jose Abreu
2023-07-28 1:36 ` Feiyang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACWXhK=Dt1WW=7HmgsYVXVB4SCB3_Cu4sUYQtC-0CWdjB7wj4A@mail.gmail.com' \
--to=chris.chenfeiyang@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=chenfeiyang@loongson.cn \
--cc=chenhuacai@loongson.cn \
--cc=dongbiao@loongson.cn \
--cc=hkallweit1@gmail.com \
--cc=joabreu@synopsys.com \
--cc=linux@armlinux.org.uk \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).