Re: [RFC PATCH net-next v3 1/4] net core: Add IFF_PROTO_DOWN support.

[Anuradha Karuppiah <anuradhak@cumulusnetworks.com>]

On Mon, Apr 27, 2015 at 11:05 PM, Scott Feldman <sfeldma@gmail.com> wrote:
> On Mon, Apr 27, 2015 at 10:38 AM,  <anuradhak@cumulusnetworks.com> wrote:
>> From: Anuradha Karuppiah <anuradhak@cumulusnetworks.com>
>>
>> This patch introduces an IFF_PROTO_DOWN flag that can be used by
>> user space applications to notify drivers that errors have been
>> detected on the device.
>>
>> Signed-off-by: Anuradha Karuppiah <anuradhak@cumulusnetworks.com>
>> Signed-off-by: Andy Gospodarek <gospo@cumulusnetworks.com>
>> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
>> Signed-off-by: Wilson Kok <wkok@cumulusnetworks.com>
>> ---
>>  include/uapi/linux/if.h |    4 ++++
>>  net/8021q/vlan_dev.c    |    3 ++-
>>  net/core/dev.c          |    2 +-
>>  3 files changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/uapi/linux/if.h b/include/uapi/linux/if.h
>> index 9cf2394..e263bd2 100644
>> --- a/include/uapi/linux/if.h
>> +++ b/include/uapi/linux/if.h
>> @@ -66,6 +66,8 @@
>>   * @IFF_LOWER_UP: driver signals L1 up. Volatile.
>>   * @IFF_DORMANT: driver signals dormant. Volatile.
>>   * @IFF_ECHO: echo sent packets. Volatile.
>> + * @IFF_PROTO_DOWN: protocol is down on the interface. Can be toggled
>> + *     through sysfs.
>
> This comment is stale, right?  I didn't see any sysfs support in the patchset.

Correct, No new sysfs has been added for this flag. But IFF_PROTO_DOWN
can be toggled via the already existing generic flags sysfs (similar
to say IFF_MULTICAST); hence the comment –

root@net-next:~# echo 0x81003 > /sys/class/net/eth0/flags

root@net-next:~# cat /sys/class/net/eth0/flags

0x81003