Re: [PATCH net-next v4 1/4] net core: Add protodown support.

[Anuradha Karuppiah <anuradhak@cumulusnetworks.com>]

On Wed, Jul 8, 2015 at 4:07 PM, Jonathan Toppins
<jtoppins@cumulusnetworks.com> wrote:
> On 7/8/15 5:04 PM, anuradhak@cumulusnetworks.com wrote:
>>
>> diff --git a/include/uapi/linux/if.h b/include/uapi/linux/if.h
>> index 9cf2394..8d60fe7 100644
>> --- a/include/uapi/linux/if.h
>> +++ b/include/uapi/linux/if.h
>> @@ -156,6 +156,12 @@ enum {
>>         IF_LINK_MODE_DORMANT,   /* limit upward transition to dormant */
>>   };
>>
>> +/* proto_flags - port state information can be passed to the switch
>> driver and
>> + * used to determine the phys state of the switch port */
>> +enum {
>> +       IF_PROTOF_DOWN          = 1<<0  /* set switch port phys state down
>> */
>
>
> It might be better to use BIT(0) provided by linux/bitopts.h
>
>> +};
>> +
>
>
Ack.