netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josh Coombs <jcoombs@staff.gwi.net>
To: sd@queasysnail.net
Cc: netdev@vger.kernel.org
Subject: Re: Bug in MACSec - stops passing traffic after approx 5TB
Date: Sun, 14 Oct 2018 16:52:24 -0400	[thread overview]
Message-ID: <CACcUnf8uYKKbE8o=LvT7cENKiuB_sBMD+2VMCCOnwa=2W=Ri4w@mail.gmail.com> (raw)
In-Reply-To: <20181014202510.GA19253@bistromath.localdomain>

On Sun, Oct 14, 2018 at 4:24 PM Sabrina Dubroca <sd@queasysnail.net> wrote:
>
> 2018-10-14, 10:59:31 -0400, Josh Coombs wrote:
> > I initially mistook this for a traffic control issue, but after
> > stripping the test beds down to just the MACSec component, I can still
> > replicate the issue.  After approximately 5TB of transfer / 4 billion
> > packets over a MACSec link it stops passing traffic.
>
> I think you're just hitting packet number exhaustion. After 2^32
> packets, the packet number would wrap to 0 and start being reused,
> which breaks the crypto used by macsec. Before this point, you have to
> add a new SA, and tell the macsec device to switch to it.

I had not considered that, I naively thought as long as I didn't
specify a replay window, it'd roll the PN over on it's own and life
would be good.  I'll test that theory tomorrow, should be easy to
prove out.

> That's why you should be using wpa_supplicant. It will monitor the
> growth of the packet number, and handle the rekey for you.

Thank you for the heads up, I'll read up on this as well.

Josh C

  reply	other threads:[~2018-10-15  4:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-14 14:59 Bug in MACSec - stops passing traffic after approx 5TB Josh Coombs
2018-10-14 20:25 ` Sabrina Dubroca
2018-10-14 20:52   ` Josh Coombs [this message]
2018-10-15 15:45     ` Josh Coombs
2018-10-17 13:45       ` Josh Coombs
2018-10-17 14:46         ` Josh Coombs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACcUnf8uYKKbE8o=LvT7cENKiuB_sBMD+2VMCCOnwa=2W=Ri4w@mail.gmail.com' \
    --to=jcoombs@staff.gwi.net \
    --cc=netdev@vger.kernel.org \
    --cc=sd@queasysnail.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).