From: "Rafał Miłecki" <zajec5@gmail.com>
To: rahul.jain@samsung.com
Cc: David Miller <davem@davemloft.net>,
Johannes Berg <johannes.berg@intel.com>,
Network Development <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Nitin Jhanwar <nitin.j@samsung.com>,
"hemanshu.s@samsung.com" <hemanshu.s@samsung.com>,
Amit Khatri <amit.khatri@samsung.com>
Subject: Re: [PATCH] Logically DeadCode
Date: Mon, 13 Jul 2015 21:58:16 +0200 [thread overview]
Message-ID: <CACna6rxRFzjs+rxP30wY-xyDmoDysbutA=xAVteWTcDR0i-oAw@mail.gmail.com> (raw)
In-Reply-To: <893988929.229281435899150021.JavaMail.weblogic@ep2mlwas07a>
On 3 July 2015 at 06:52, Rahul Jain <rahul.jain@samsung.com> wrote:
> From 0c34030166a150d6d9f1ab52e7bb40a5440a68c2 Mon Sep 17 00:00:00 2001
> From: Rahul Jain <rahul.jain@samsung.com>
> Date: Fri, 3 Jul 2015 10:19:12 +0530
> Subject: [PATCH] Logically DeadCode
You didn't use any prefix for the commit message, it's unclear
(Logically DeadCode what?), no description, you touch two code places
at once.
Please fix above problems and resend.
prev parent reply other threads:[~2015-07-13 19:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 4:52 [PATCH] Logically DeadCode Rahul Jain
2015-07-13 19:58 ` Rafał Miłecki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACna6rxRFzjs+rxP30wY-xyDmoDysbutA=xAVteWTcDR0i-oAw@mail.gmail.com' \
--to=zajec5@gmail.com \
--cc=amit.khatri@samsung.com \
--cc=davem@davemloft.net \
--cc=hemanshu.s@samsung.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nitin.j@samsung.com \
--cc=rahul.jain@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).