* [PATCH] Logically DeadCode
@ 2015-07-03 4:52 Rahul Jain
2015-07-13 19:58 ` Rafał Miłecki
0 siblings, 1 reply; 2+ messages in thread
From: Rahul Jain @ 2015-07-03 4:52 UTC (permalink / raw)
To: davem, johannes.berg, netdev, linux-kernel, linux-wireless
Cc: Nitin Jhanwar, hemanshu.s@samsung.com, Amit Khatri
hello,
From 0c34030166a150d6d9f1ab52e7bb40a5440a68c2 Mon Sep 17 00:00:00 2001
From: Rahul Jain <rahul.jain@samsung.com>
Date: Fri, 3 Jul 2015 10:19:12 +0530
Subject: [PATCH] Logically DeadCode
Signed-off-by: Rahul Jain <rahul.jain@samsung.com>
Signed-off-by: Amit Khatri <amit.khatri@samsung.com>
---
net/wireless/util.c | 3 ---
net/wireless/wext-compat.c | 3 ---
2 files changed, 6 deletions(-)
diff --git a/net/wireless/util.c b/net/wireless/util.c
index baf7218..507e894 100644
--- a/net/wireless/util.c
+++ b/net/wireless/util.c
@@ -1009,9 +1009,6 @@ int cfg80211_change_iface(struct cfg80211_registered_device *rdev,
case NUM_NL80211_IFTYPES:
/* not happening */
break;
- case NL80211_IFTYPE_P2P_DEVICE:
- WARN_ON(1);
- break;
}
}
diff --git a/net/wireless/wext-compat.c b/net/wireless/wext-compat.c
index fd68283..8de1b64 100644
--- a/net/wireless/wext-compat.c
+++ b/net/wireless/wext-compat.c
@@ -387,9 +387,6 @@ static int cfg80211_wext_siwretry(struct net_device *dev,
changed |= WIPHY_PARAM_RETRY_SHORT;
}
- if (!changed)
- return 0;
-
err = rdev_set_wiphy_params(rdev, changed);
if (err) {
wdev->wiphy->retry_short = oshort;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Logically DeadCode
2015-07-03 4:52 [PATCH] Logically DeadCode Rahul Jain
@ 2015-07-13 19:58 ` Rafał Miłecki
0 siblings, 0 replies; 2+ messages in thread
From: Rafał Miłecki @ 2015-07-13 19:58 UTC (permalink / raw)
To: rahul.jain
Cc: David Miller, Johannes Berg, Network Development,
Linux Kernel Mailing List, linux-wireless@vger.kernel.org,
Nitin Jhanwar, hemanshu.s@samsung.com, Amit Khatri
On 3 July 2015 at 06:52, Rahul Jain <rahul.jain@samsung.com> wrote:
> From 0c34030166a150d6d9f1ab52e7bb40a5440a68c2 Mon Sep 17 00:00:00 2001
> From: Rahul Jain <rahul.jain@samsung.com>
> Date: Fri, 3 Jul 2015 10:19:12 +0530
> Subject: [PATCH] Logically DeadCode
You didn't use any prefix for the commit message, it's unclear
(Logically DeadCode what?), no description, you touch two code places
at once.
Please fix above problems and resend.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-13 19:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-03 4:52 [PATCH] Logically DeadCode Rahul Jain
2015-07-13 19:58 ` Rafał Miłecki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).