* [PATCH] b43legacy: Remove unused function
@ 2015-01-06 17:59 Rickard Strandqvist
2015-01-06 18:08 ` Larry Finger
2015-01-06 18:19 ` Rafał Miłecki
0 siblings, 2 replies; 3+ messages in thread
From: Rickard Strandqvist @ 2015-01-06 17:59 UTC (permalink / raw)
To: Larry Finger, Stefano Brivio
Cc: Rickard Strandqvist, Kalle Valo,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
b43-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org>
---
drivers/net/wireless/b43legacy/radio.c | 19 -------------------
drivers/net/wireless/b43legacy/radio.h | 1 -
2 files changed, 20 deletions(-)
diff --git a/drivers/net/wireless/b43legacy/radio.c b/drivers/net/wireless/b43legacy/radio.c
index 8961776..9501420 100644
--- a/drivers/net/wireless/b43legacy/radio.c
+++ b/drivers/net/wireless/b43legacy/radio.c
@@ -1743,25 +1743,6 @@ u16 freq_r3A_value(u16 frequency)
return value;
}
-void b43legacy_radio_set_tx_iq(struct b43legacy_wldev *dev)
-{
- static const u8 data_high[5] = { 0x00, 0x40, 0x80, 0x90, 0xD0 };
- static const u8 data_low[5] = { 0x00, 0x01, 0x05, 0x06, 0x0A };
- u16 tmp = b43legacy_radio_read16(dev, 0x001E);
- int i;
- int j;
-
- for (i = 0; i < 5; i++) {
- for (j = 0; j < 5; j++) {
- if (tmp == (data_high[i] | data_low[j])) {
- b43legacy_phy_write(dev, 0x0069, (i - j) << 8 |
- 0x00C0);
- return;
- }
- }
- }
-}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] b43legacy: Remove unused function
2015-01-06 17:59 [PATCH] b43legacy: Remove unused function Rickard Strandqvist
@ 2015-01-06 18:08 ` Larry Finger
2015-01-06 18:19 ` Rafał Miłecki
1 sibling, 0 replies; 3+ messages in thread
From: Larry Finger @ 2015-01-06 18:08 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Kalle Valo, linux-wireless, b43-dev, netdev, linux-kernel
On 01/06/2015 11:59 AM, Rickard Strandqvist wrote:
> Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/net/wireless/b43legacy/radio.c | 19 -------------------
> drivers/net/wireless/b43legacy/radio.h | 1 -
> 2 files changed, 20 deletions(-)
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry
>
> diff --git a/drivers/net/wireless/b43legacy/radio.c b/drivers/net/wireless/b43legacy/radio.c
> index 8961776..9501420 100644
> --- a/drivers/net/wireless/b43legacy/radio.c
> +++ b/drivers/net/wireless/b43legacy/radio.c
> @@ -1743,25 +1743,6 @@ u16 freq_r3A_value(u16 frequency)
> return value;
> }
>
> -void b43legacy_radio_set_tx_iq(struct b43legacy_wldev *dev)
> -{
> - static const u8 data_high[5] = { 0x00, 0x40, 0x80, 0x90, 0xD0 };
> - static const u8 data_low[5] = { 0x00, 0x01, 0x05, 0x06, 0x0A };
> - u16 tmp = b43legacy_radio_read16(dev, 0x001E);
> - int i;
> - int j;
> -
> - for (i = 0; i < 5; i++) {
> - for (j = 0; j < 5; j++) {
> - if (tmp == (data_high[i] | data_low[j])) {
> - b43legacy_phy_write(dev, 0x0069, (i - j) << 8 |
> - 0x00C0);
> - return;
> - }
> - }
> - }
> -}
> -
> int b43legacy_radio_selectchannel(struct b43legacy_wldev *dev,
> u8 channel,
> int synthetic_pu_workaround)
> diff --git a/drivers/net/wireless/b43legacy/radio.h b/drivers/net/wireless/b43legacy/radio.h
> index bccb3d7..dd2976d 100644
> --- a/drivers/net/wireless/b43legacy/radio.h
> +++ b/drivers/net/wireless/b43legacy/radio.h
> @@ -92,7 +92,6 @@ void b43legacy_nrssi_hw_write(struct b43legacy_wldev *dev, u16 offset, s16 val);
> void b43legacy_nrssi_hw_update(struct b43legacy_wldev *dev, u16 val);
> void b43legacy_nrssi_mem_update(struct b43legacy_wldev *dev);
>
> -void b43legacy_radio_set_tx_iq(struct b43legacy_wldev *dev);
> u16 b43legacy_radio_calibrationvalue(struct b43legacy_wldev *dev);
>
> #endif /* B43legacy_RADIO_H_ */
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] b43legacy: Remove unused function
2015-01-06 17:59 [PATCH] b43legacy: Remove unused function Rickard Strandqvist
2015-01-06 18:08 ` Larry Finger
@ 2015-01-06 18:19 ` Rafał Miłecki
1 sibling, 0 replies; 3+ messages in thread
From: Rafał Miłecki @ 2015-01-06 18:19 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Larry Finger, Stefano Brivio, Network Development,
linux-wireless@vger.kernel.org, Linux Kernel Mailing List,
b43-dev
On 6 January 2015 at 18:59, Rickard Strandqvist
<rickard_strandqvist@spectrumdigital.se> wrote:
> Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Acked-by: Rafał Miłecki <zajec5@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-06 18:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-06 17:59 [PATCH] b43legacy: Remove unused function Rickard Strandqvist
2015-01-06 18:08 ` Larry Finger
2015-01-06 18:19 ` Rafał Miłecki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).