From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7421C43381 for ; Mon, 1 Apr 2019 13:31:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 73B0B20880 for ; Mon, 1 Apr 2019 13:31:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zl1Q0TPm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728027AbfDANbW (ORCPT ); Mon, 1 Apr 2019 09:31:22 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:42562 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726608AbfDANbW (ORCPT ); Mon, 1 Apr 2019 09:31:22 -0400 Received: by mail-qt1-f194.google.com with SMTP id p20so10484387qtc.9 for ; Mon, 01 Apr 2019 06:31:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=OlIqRm4zzZ0Jv2hKF2HakbY+sXLJTS4NArziRBxOLZ0=; b=Zl1Q0TPmoDDzQu275S0KFKGPV7DgBu+4oXFGOs8bJHNnuVIwdkdDXrKUyza0Jup9vs DmdN5t5B35OO3EFde0xkqOvb8WfXe6gnHE+p5HPKP7JdaSpcDonCqZOO3bK0q/ORC9c5 6/FTjgs10W6uDggcp5yqmA29E+d1yctEMEfiDgHQsrfa44EVFPNzoafTxzNkq2EO+kCX YdQ9NdTbROs2WxSJhMkOwcUxOVSi95EkwiO9Pqnet1v/bG7H1jcIbaFcUualw+sb96p5 cnQ7SbmGwSOBvbDtqQgF855RnxQk3o5uSchtN/FkaApk5/3t7E4BDHLQBYAdt4ReN+W4 eKTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=OlIqRm4zzZ0Jv2hKF2HakbY+sXLJTS4NArziRBxOLZ0=; b=fnVlUHz+Z9boVL+zBamgi6t8DtpIdynWD5b7orcWm2eaFj5tz5Wvg7SFELZLoHQcST D8PQwKNC1PpVo3EiE6KFvNqJPz1lJeMYpJs4cSHZWGzh5p2sAbfKcoxGH7hpAuFGAgGK OJ5AUBTxfKKUNPAsdLG0Ar/REylSRmeyMJMt50OPmdtX8nEX2v5egP5PscqIflZwzka+ O5TF0X0K/SnKlHyI53M9bieA3pJHd88Qf7+xOMQyRRGAFVDyWWMt+KIxw7KP6ccMBzTt VNBOQ9PrVzk6Mw3Kn9caic3c41aItki6o5m3qgPcUVvi9G3ab4LvWlsVBdMgcJxaZQso FZOQ== X-Gm-Message-State: APjAAAVsYoUADFXR5EogkvM59HOXVL1Wuu7WH2BObdzO5KzMa7qWvgSo oo4kpMvlHfSy7LrvTuYJ4v984MG6QNSpN9STVf8= X-Google-Smtp-Source: APXvYqwVjlsAuworY8ch8ljX2eUEGdQhZwu/qYsNUhBYwkufUC2zg1+FSmYzZabW1aTjRTOtF2n+Hv3+6s5ViIezrzE= X-Received: by 2002:a0c:9326:: with SMTP id d35mr39268051qvd.108.1554125481126; Mon, 01 Apr 2019 06:31:21 -0700 (PDT) MIME-Version: 1.0 References: <20190331174005.5841-1-gautamramk@gmail.com> <87zhpaorss.fsf@toke.dk> In-Reply-To: <87zhpaorss.fsf@toke.dk> From: Gautam Ramakrishnan Date: Mon, 1 Apr 2019 19:01:09 +0530 Message-ID: Subject: Re: [RFC net-next 0/2] net: sched: add Flow Queue PIE AQM To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Jamal Hadi Salim , davem@davemloft.net, netdev@vger.kernel.org, "Mohit P . Tahiliani" , "Sachin D . Patil" , Mohit Bhasi , "V . Saicharan" , Leslie Monis , Dave Taht Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Apr 01, 2019 at 02:04:19PM +0200, Toke H=C3=B8iland-J=C3=B8rgensen = wrote: > Gautam Ramakrishnan writes: > > > Flow Queue PIE packet scheduler > > > > This patch series implements the Flow Queue Proportional > > Integral Controller (FQ-PIE) active queue management > > algorithm. It is an enhancement over the PIE algorithm. > > It integrates the PIE aqm with a deficit round robin > > scheme. > > > > It is implemented over RFC 8033 aligned version of PIE. > > In this patch, Little's law is used for queue delay > > estimation like PIE. This patch doesn't yet have the > > timestamp based queue delay estimator like freebsd, that > > Dave Taht thinks is better. > > > > We are looking for suggestions on cleanups and > > improvements for this patch. > > Is the fq_ part basically identical to fq_codel? Might make sense to > share some code in that case; might not be a trivial refactoring, > though... > > -Toke The fq_ part is mostly the same, except for the batch dropping. But the structure of flows are different. Any particular suggestions on the refactoring? -Gautam