From: takeru hayasaka <hayatake396@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] ethtool: ice: Support for RSS settings to GTP from ethtool
Date: Thu, 12 Oct 2023 10:08:00 +0900 [thread overview]
Message-ID: <CADFiAc+67wdcS5enobbty-_U9SGX9Mr-C_0ipU_KJAV+h-t_Tg@mail.gmail.com> (raw)
In-Reply-To: <20231011094114.4d8f24c7@kernel.org>
> I think we should expose TEID as a field. It's easier to understand
> the API if fields are all listed, and not implied by the flow hash.
Jakub san Thank you for your feedback!
I would like to make changes and send them as a patch for the next version.
2023年10月12日(木) 1:41 Jakub Kicinski <kuba@kernel.org>:
>
> On Wed, 11 Oct 2023 14:25:55 +0900 takeru hayasaka wrote:
> > > Regarding the patch - you are only adding flow types, not a new field
> > > (which are defined as RXH_*). If we want to hash on an extra field,
> > > I think we need to specify that field as well?
> >
> > I've been really struggling with this...
> > When I read the Intel ICE documentation, it suggests that in RSS, TEID
> > can be an additional input.
> > However, I couldn't think of a reason not to include TEID when
> > enabling RSS for GTP cases.
> >
> > https://www.intel.com/content/www/us/en/content-details/617015/intel-ethernet-controller-e810-dynamic-device-personalization-ddp-technology-guide.html
> > (cf. Table 8. Patterns and Input Sets for iavf RSS)
> >
> > However, for Flow Director, it's clear that you'd want to include the
> > TEID field. But since I found that someone from Intel has already
> > configured it to use TEID with Flow Director, I thought maybe we don't
> > need to add the TEID parameter for now.
> >
> > https://patchwork.ozlabs.org/project/intel-wired-lan/cover/20210126065206.137422-1-haiyue.wang@intel.com/
> >
> > If we want to include something other than TEID (e.g., QFI) in Flow
> > Director, I think it would be better to prepare a new field.
>
> I think we should expose TEID as a field. It's easier to understand
> the API if fields are all listed, and not implied by the flow hash.
next prev parent reply other threads:[~2023-10-12 1:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-08 7:52 [PATCH net-next] ethtool: ice: Support for RSS settings to GTP from ethtool Takeru Hayasaka
2023-10-10 19:32 ` Jakub Kicinski
2023-10-11 1:56 ` takeru hayasaka
2023-10-11 2:10 ` Jakub Kicinski
2023-10-11 5:25 ` takeru hayasaka
2023-10-11 16:41 ` Jakub Kicinski
2023-10-12 1:08 ` takeru hayasaka [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-10-08 6:36 Takeru Hayasaka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADFiAc+67wdcS5enobbty-_U9SGX9Mr-C_0ipU_KJAV+h-t_Tg@mail.gmail.com \
--to=hayatake396@gmail.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).