netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Siwei Liu <loseweigh@gmail.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: si-wei liu <si-wei.liu@oracle.com>,
	Roman Kagan <rkagan@virtuozzo.com>,
	Venu Busireddy <venu.busireddy@oracle.com>,
	Marcel Apfelbaum <marcel@redhat.com>,
	virtio-dev@lists.oasis-open.org, qemu-devel@nongnu.org,
	"Samudrala, Sridhar" <sridhar.samudrala@intel.com>,
	Alexander Duyck <alexander.h.duyck@intel.com>,
	Netdev <netdev@vger.kernel.org>
Subject: Re: Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...
Date: Tue, 10 Jul 2018 11:56:28 -0700	[thread overview]
Message-ID: <CADGSJ21sjds8h4Djvu221WeEnyVCbo0WbL9a_SUkntUvx5_S2A@mail.gmail.com> (raw)
In-Reply-To: <20180710045614-mutt-send-email-mst@kernel.org>

On Mon, Jul 9, 2018 at 6:58 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Mon, Jul 09, 2018 at 06:11:53PM -0700, si-wei liu wrote:
>> What do we buy
>> for using a random address during initial discovery and requiring VF to
>> complete the handshake?
>
> I don't see advantages to using a random address that is then
> changed either: changing a MAC causes network downtime for most users.
>
Definitely.

I see Linux host stack fundamentally different with Windows, it's
non-sense to duplicate what Hyper-V is doing especially if there's no
extra benefit.

>> Less network downtime during datapath switching?
>> Sorry but that's not a key factor at all for our main goal - live migration.
>
> Isn't avoiding downtime what makes the migration "live"?
> If you don't care about it at all just remove the device
> and migrate without all these tricks.

Apparently this downtime is not avoidable even if guest initiates the
switch-over when it is done on Linux host stack. Unless the NIC
supports adding duplicate MAC filters with one has higher priority
than the other when both are present. I feel there's very little or
perhaps zero improvement for the downtime if moving to a
guest-initiated datapath switching model.

However, since this downtime is intermittent and generally
unnoticeable with a few packet drops, network should be resilient in
recovering from the drops. My point is that unless we can move to a
datapath switching model with zero downtime theoretically, this kind
of minor optimization offers very little help in general.

Regards,
-Siwei



>
>
> --
> MST
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
>

      reply	other threads:[~2018-07-10 18:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180629221907.3662-1-venu.busireddy@oracle.com>
     [not found] ` <20180702161404.GA2339@rkaganb.sw.ru>
     [not found]   ` <449f1449-ddf6-cd95-976c-14d04d8d503a@oracle.com>
     [not found]     ` <20180703095825.GC30904@rkaganb.sw.ru>
     [not found]       ` <d5db37d0-5eaf-8942-8ab7-d73057a67e6f@oracle.com>
     [not found]         ` <20180709130035.GA6271@rkaganb.sw.ru>
2018-07-10  1:11           ` [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices si-wei liu
2018-07-10  1:54             ` Michael S. Tsirkin
2018-07-11  0:07               ` Siwei Liu
2018-07-11  9:53                 ` Cornelia Huck
2018-07-12  9:37                   ` Siwei Liu
2018-07-12 11:31                     ` Cornelia Huck
2018-07-12 20:52                       ` Siwei Liu
2018-07-12 21:00                         ` Michael S. Tsirkin
2018-07-12 22:19                           ` Siwei Liu
2018-07-13  1:20                             ` Samudrala, Sridhar
2018-07-13  3:28                               ` Michael S. Tsirkin
2018-07-13  9:15                               ` Cornelia Huck
2018-07-12 19:18                   ` Michael S. Tsirkin
2018-07-10  1:58             ` Michael S. Tsirkin
2018-07-10 18:56               ` Siwei Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADGSJ21sjds8h4Djvu221WeEnyVCbo0WbL9a_SUkntUvx5_S2A@mail.gmail.com \
    --to=loseweigh@gmail.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rkagan@virtuozzo.com \
    --cc=si-wei.liu@oracle.com \
    --cc=sridhar.samudrala@intel.com \
    --cc=venu.busireddy@oracle.com \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).