From: Jordan Rife <jrife@google.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org, dborkman@kernel.org,
philipp.reisner@linbit.com, lars.ellenberg@linbit.com,
christoph.boehmwalder@linbit.com, axboe@kernel.dk,
airlied@redhat.com, chengyou@linux.alibaba.com,
kaishen@linux.alibaba.com, jgg@ziepe.ca, leon@kernel.org,
bmt@zurich.ibm.com, isdn@linux-pingi.de, ccaulfie@redhat.com,
teigland@redhat.com, mark@fasheh.com, jlbec@evilplan.org,
joseph.qi@linux.alibaba.com, sfrench@samba.org,
pc@manguebit.com, lsahlber@redhat.com, sprasad@microsoft.com,
tom@talpey.com, horms@verge.net.au, ja@ssi.bg,
pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de,
santosh.shilimkar@oracle.com
Subject: Re: [PATCH net v3 3/3] net: prevent address rewrite in kernel_bind()
Date: Tue, 19 Sep 2023 09:15:55 -0700 [thread overview]
Message-ID: <CADKFtnR+dbZf9Xc5k_62Ur7N8N2=ghvYY6GD8DgxruOPQhQiZw@mail.gmail.com> (raw)
In-Reply-To: <6509ac739ffe6_1dda1929434@willemb.c.googlers.com.notmuch>
> Is there any real risk of callers passing these lengths out of bound?
>
> These are in-kernel callers, so they are by necessity trusted code. If
> there is a buggy caller, that will be addressed directly, rather than
> through these callee precondition checks.
Not to my knowledge, just being paranoid. I will remove the precondition checks.
> You want to pass &address?
Yep. Good catch.
-Jordan
prev parent reply other threads:[~2023-09-19 16:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 0:46 [PATCH net v3 3/3] net: prevent address rewrite in kernel_bind() Jordan Rife
2023-09-19 14:13 ` Willem de Bruijn
2023-09-19 16:15 ` Jordan Rife [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADKFtnR+dbZf9Xc5k_62Ur7N8N2=ghvYY6GD8DgxruOPQhQiZw@mail.gmail.com' \
--to=jrife@google.com \
--cc=airlied@redhat.com \
--cc=axboe@kernel.dk \
--cc=bmt@zurich.ibm.com \
--cc=ccaulfie@redhat.com \
--cc=chengyou@linux.alibaba.com \
--cc=christoph.boehmwalder@linbit.com \
--cc=davem@davemloft.net \
--cc=dborkman@kernel.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@verge.net.au \
--cc=isdn@linux-pingi.de \
--cc=ja@ssi.bg \
--cc=jgg@ziepe.ca \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=kadlec@netfilter.org \
--cc=kaishen@linux.alibaba.com \
--cc=kuba@kernel.org \
--cc=lars.ellenberg@linbit.com \
--cc=leon@kernel.org \
--cc=lsahlber@redhat.com \
--cc=mark@fasheh.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=pc@manguebit.com \
--cc=philipp.reisner@linbit.com \
--cc=santosh.shilimkar@oracle.com \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=teigland@redhat.com \
--cc=tom@talpey.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).