From: Neal Cardwell <ncardwell@google.com>
To: Octavian Purdila <octavian.purdila@intel.com>
Cc: Netdev <netdev@vger.kernel.org>,
Daniel Lee <longinus00@gmail.com>,
Yuchung Cheng <ycheng@google.com>, Jerry Chu <hkchu@google.com>
Subject: Re: [net-next v2 02/13] tcp: tcp_v[46]_conn_request: fix snt_synack initialization
Date: Mon, 30 Jun 2014 15:11:33 -0400 [thread overview]
Message-ID: <CADVnQy=Fu-fJDczTLjQPreGq2-++S9sp2akj84Orv5p_b3Qc=g@mail.gmail.com> (raw)
In-Reply-To: <CAE1zotKXSqy0O+OQq1f+ab7k3hL4ntMwk3CX4pOYUXoVeGjb7A@mail.gmail.com>
On Mon, Jun 30, 2014 at 7:50 AM, Octavian Purdila
<octavian.purdila@intel.com> wrote:
> In that case perhaps it is better to add a new field (or rename the
> existing one if it is not needed anymore) to store the syn arrival
> time? I think it is confusing to store the syn arrival time in the
> "synack sent time" field.
That would be reasonable, but I think the longstanding "snt_synack"
name is also good, since the primary purpose of that field is to
measure the RTT of the SYNACK packet.
neal
next prev parent reply other threads:[~2014-06-30 19:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 14:09 [net-next v2 00/13] remove code duplication in tcp_v[46]_conn_request Octavian Purdila
2014-06-25 14:09 ` [net-next v2 01/13] tcp: cookie_v4_init_sequence: skb should be const Octavian Purdila
2014-06-25 14:09 ` [net-next v2 02/13] tcp: tcp_v[46]_conn_request: fix snt_synack initialization Octavian Purdila
2014-06-28 2:16 ` Neal Cardwell
2014-06-28 2:24 ` Neal Cardwell
2014-06-30 11:50 ` Octavian Purdila
2014-06-30 19:11 ` Neal Cardwell [this message]
2014-06-30 21:00 ` Octavian Purdila
2014-07-01 2:24 ` Neal Cardwell
2014-06-25 14:09 ` [net-next v2 03/13] net: remove inet6_reqsk_alloc Octavian Purdila
2014-06-25 17:59 ` Cong Wang
2014-06-25 18:04 ` Octavian Purdila
2014-06-25 14:09 ` [net-next v2 04/13] tcp: add init_req method to tcp_request_sock_ops Octavian Purdila
2014-06-25 14:09 ` [net-next v2 05/13] tcp: add init_cookie_seq " Octavian Purdila
2014-06-25 14:09 ` [net-next v2 06/13] tcp: add route_req " Octavian Purdila
2014-06-25 14:09 ` [net-next v2 07/13] tcp: move around a few calls in tcp_v6_conn_request Octavian Purdila
2014-06-25 14:29 ` Paul Moore
2014-06-25 14:09 ` [net-next v2 08/13] tcp: add init_seq method to tcp_request_sock_ops Octavian Purdila
2014-06-25 14:09 ` [net-next v2 09/13] tcp: add send_synack " Octavian Purdila
2014-06-25 14:09 ` [net-next v2 10/13] tcp: unify tcp_v4_rtx_synack and tcp_v6_rtx_synack Octavian Purdila
2014-06-25 14:10 ` [net-next v2 11/13] tcp: add mss_clamp to tcp_request_sock_ops Octavian Purdila
2014-06-25 14:10 ` [net-next v2 12/13] tcp: add queue_add_hash " Octavian Purdila
2014-06-25 19:05 ` Cong Wang
2014-06-25 14:10 ` [net-next v2 13/13] tcp: add tcp_conn_request Octavian Purdila
2014-06-27 22:54 ` [net-next v2 00/13] remove code duplication in tcp_v[46]_conn_request David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADVnQy=Fu-fJDczTLjQPreGq2-++S9sp2akj84Orv5p_b3Qc=g@mail.gmail.com' \
--to=ncardwell@google.com \
--cc=hkchu@google.com \
--cc=longinus00@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=octavian.purdila@intel.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).