From: Neal Cardwell <ncardwell@google.com>
To: David Laight <David.Laight@aculab.com>
Cc: "Yuchung Cheng" <ycheng@google.com>,
"Eric Dumazet" <eric.dumazet@gmail.com>,
"Sébastien Barré" <sebastien.barre@uclouvain.be>,
"David Miller" <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
"Gregory Detal" <gregory.detal@uclouvain.be>,
"Nandita Dukkipati" <nanditad@google.com>
Subject: Re: [PATCH net-next v2] tcp: avoid reducing cwnd when ACK+DSACK is received
Date: Mon, 12 Jan 2015 10:02:45 -0500 [thread overview]
Message-ID: <CADVnQy=ceATQE=9UCCJmHWaXP9FjMQoCVt_WNxpT9R0C__5BwA@mail.gmail.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1CAC5844@AcuExch.aculab.com>
On Mon, Jan 12, 2015 at 6:52 AM, David Laight <David.Laight@aculab.com> wrote:
>> if (flag & FLAG_DSACKING_ACK) {
>> /* This DSACK means original and TLP probe arrived; no loss */
>> tp->tlp_high_seq = 0;
>
> I think I'd add a 'return' here.
What's the benefit of adding 'return' in those two spots? That adds
extra code to read, with no change in behavior, and no increase in
maintainability.
neal
prev parent reply other threads:[~2015-01-12 15:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 12:20 [PATCH net-next v2] tcp: avoid reducing cwnd when ACK+DSACK is received Sébastien Barré
2015-01-08 15:07 ` Eric Dumazet
2015-01-08 15:24 ` Sébastien Barré
2015-01-08 15:43 ` Neal Cardwell
2015-01-08 16:00 ` Sébastien Barré
2015-01-08 15:59 ` Eric Dumazet
2015-01-08 15:19 ` Eric Dumazet
2015-01-08 15:39 ` Sébastien Barré
2015-01-08 15:49 ` Neal Cardwell
2015-01-08 15:52 ` Neal Cardwell
2015-01-08 16:25 ` Eric Dumazet
2015-01-08 17:17 ` Eric Dumazet
2015-01-08 17:27 ` Eric Dumazet
2015-01-09 19:43 ` Yuchung Cheng
2015-01-09 20:36 ` Neal Cardwell
2015-01-10 11:51 ` Sébastien Barré
2015-01-10 17:37 ` Eric Dumazet
2015-01-12 11:52 ` David Laight
2015-01-12 15:02 ` Neal Cardwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADVnQy=ceATQE=9UCCJmHWaXP9FjMQoCVt_WNxpT9R0C__5BwA@mail.gmail.com' \
--to=ncardwell@google.com \
--cc=David.Laight@aculab.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=gregory.detal@uclouvain.be \
--cc=nanditad@google.com \
--cc=netdev@vger.kernel.org \
--cc=sebastien.barre@uclouvain.be \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).