From: Neal Cardwell <ncardwell@google.com>
To: Andrew Shewmaker <agshew@gmail.com>
Cc: Yuchung Cheng <ycheng@google.com>,
David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next 2/7] tcp: track min RTT using windowed min-filter
Date: Sun, 18 Oct 2015 10:33:41 -0400 [thread overview]
Message-ID: <CADVnQyk1e+csk_kX3D+E2CCeBi3sAKGjePEn3bAWceVFNf02Fg@mail.gmail.com> (raw)
In-Reply-To: <20151014092800.GA3748@mininet-vm>
On Wed, Oct 14, 2015 at 5:28 AM, Andrew Shewmaker <agshew@gmail.com> wrote:
>> diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
>> index 38743e5..e177386 100644
>> --- a/net/ipv4/tcp_input.c
>> +++ b/net/ipv4/tcp_input.c
> ...
>> @@ -2961,7 +3028,7 @@ void tcp_synack_rtt_meas(struct sock *sk, struct request_sock *req)
>> rtt_us = skb_mstamp_us_delta(&now, &tcp_rsk(req)->snt_synack);
>> }
>>
>> - tcp_ack_update_rtt(sk, FLAG_SYN_ACKED, rtt_us, -1L);
>> + tcp_ack_update_rtt(sk, FLAG_SYN_ACKED, rtt_us, -1L, rtt_us);
>> }
>
> This didn't apply to net-next for me. I see seq_rtt_us instead of
> rtt_us and a check on the existence of tp->srtt_us. Maybe I've
> misapplied the patch?
This patch series applies cleanly for me against David Miller's
net-next at SHA1 4be3158 (from Friday Oct 16). (Using "git am" on the
mbox patches from http://patchwork.ozlabs.org/project/netdev/list/
...)
On top of what SHA1 are you applying the series?
neal
next prev parent reply other threads:[~2015-10-18 14:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-17 4:57 [PATCH net-next 0/7] RACK loss detection Yuchung Cheng
2015-10-17 4:57 ` [PATCH net-next 1/7] tcp: apply Kern's check on RTTs used for congestion control Yuchung Cheng
2016-02-02 19:30 ` Kenneth Klette Jonassen
2016-02-02 23:28 ` Yuchung Cheng
2015-10-17 4:57 ` [PATCH net-next 2/7] tcp: track min RTT using windowed min-filter Yuchung Cheng
2015-10-14 9:28 ` Andrew Shewmaker
2015-10-18 14:33 ` Neal Cardwell [this message]
2015-10-14 13:25 ` Andrew Shewmaker
2015-10-19 4:39 ` Andrew Shewmaker
2015-10-17 4:57 ` [PATCH net-next 3/7] tcp: remove tcp_mark_lost_retrans() Yuchung Cheng
2015-10-17 4:57 ` [PATCH net-next 4/7] tcp: add tcp_tsopt_ecr_before helper Yuchung Cheng
2015-10-17 4:57 ` [PATCH net-next 5/7] tcp: skb_mstamp_after helper Yuchung Cheng
2015-10-17 4:57 ` [PATCH net-next 6/7] tcp: track the packet timings in RACK Yuchung Cheng
2015-10-17 4:57 ` [PATCH net-next 7/7] tcp: use RACK to detect losses Yuchung Cheng
2015-10-21 14:01 ` [PATCH net-next 0/7] RACK loss detection David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADVnQyk1e+csk_kX3D+E2CCeBi3sAKGjePEn3bAWceVFNf02Fg@mail.gmail.com \
--to=ncardwell@google.com \
--cc=agshew@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).