From: Neal Cardwell <ncardwell@google.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Yuchung Cheng <ycheng@google.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 2/4] tcp_metrics: properly set tp->snd_ssthresh in tcp_init_metrics()
Date: Sun, 24 Sep 2023 12:09:11 -0400 [thread overview]
Message-ID: <CADVnQym4suwOn7w7zRHMjzEpQTzDwU5ZanndhJMj2s+4Rx32OQ@mail.gmail.com> (raw)
In-Reply-To: <20230922220356.3739090-3-edumazet@google.com>
On Fri, Sep 22, 2023 at 6:04 PM Eric Dumazet <edumazet@google.com> wrote:
>
> We need to set tp->snd_ssthresh to TCP_INFINITE_SSTHRESH
> in the case tcp_get_metrics() fails for some reason.
>
> Fixes: 9ad7c049f0f7 ("tcp: RFC2988bis + taking RTT sample from 3WHS for the passive open side")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
Acked-by: Neal Cardwell <ncardwell@google.com>
neal
next prev parent reply other threads:[~2023-09-24 16:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 22:03 [PATCH net-next 0/4] tcp_metrics: four fixes Eric Dumazet
2023-09-22 22:03 ` [PATCH net-next 1/4] tcp_metrics: add missing barriers on delete Eric Dumazet
2023-09-23 11:09 ` David Ahern
2023-09-24 16:09 ` Neal Cardwell
2023-09-22 22:03 ` [PATCH net-next 2/4] tcp_metrics: properly set tp->snd_ssthresh in tcp_init_metrics() Eric Dumazet
2023-09-23 11:08 ` David Ahern
2023-09-24 16:09 ` Neal Cardwell [this message]
2023-09-22 22:03 ` [PATCH net-next 3/4] tcp_metrics: do not create an entry from tcp_init_metrics() Eric Dumazet
2023-09-23 11:09 ` David Ahern
2023-09-24 16:09 ` Neal Cardwell
2023-09-22 22:03 ` [PATCH net-next 4/4] tcp_metrics: optimize tcp_metrics_flush_all() Eric Dumazet
2023-09-23 11:07 ` David Ahern
2023-10-03 8:04 ` Paolo Abeni
2023-10-03 14:29 ` David Ahern
2023-09-24 16:08 ` Neal Cardwell
2023-10-03 9:40 ` [PATCH net-next 0/4] tcp_metrics: four fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADVnQym4suwOn7w7zRHMjzEpQTzDwU5ZanndhJMj2s+4Rx32OQ@mail.gmail.com \
--to=ncardwell@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).