From: Neal Cardwell <ncardwell@google.com>
To: Yuchung Cheng <ycheng@google.com>
Cc: David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net] tcp: only take RTT from timestamps if new data is acked
Date: Thu, 24 Oct 2013 13:02:41 -0400 [thread overview]
Message-ID: <CADVnQymFsQ8MYzi3NLLEXfQB25z-A-ELMyWJcD+2Qasc8mX8XA@mail.gmail.com> (raw)
In-Reply-To: <1382630125-21416-1-git-send-email-ycheng@google.com>
On Thu, Oct 24, 2013 at 11:55 AM, Yuchung Cheng <ycheng@google.com> wrote:
> Patch ed08495c3 "tcp: use RTT from SACK for RTO" has a bug that
> it does not check if the ACK acknowledge new data before taking
> the RTT sample from TCP timestamps. This patch adds the check
> back as required by the RFC.
>
> Signed-off-by: Yuchung Cheng <ycheng@google.com>
> ---
> net/ipv4/tcp_input.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Acked-by: Neal Cardwell <ncardwell@google.com>
neal
next prev parent reply other threads:[~2013-10-24 17:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 15:55 [PATCH net] tcp: only take RTT from timestamps if new data is acked Yuchung Cheng
2013-10-24 17:02 ` Neal Cardwell [this message]
2013-10-24 19:55 ` Eric Dumazet
2013-10-27 20:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADVnQymFsQ8MYzi3NLLEXfQB25z-A-ELMyWJcD+2Qasc8mX8XA@mail.gmail.com \
--to=ncardwell@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).