Re: [PATCH v2 1/1] tcp: fixing TLP's FIN recovery

[Neal Cardwell <ncardwell@google.com>]

On Thu, Jun 12, 2014 at 1:36 PM, Nandita Dukkipati <nanditad@google.com> wrote:
> On Thu, Jun 12, 2014 at 8:28 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> On Thu, 2014-06-12 at 17:08 +0200, Per Hurtig wrote:
>>> Fix to a problem observed when losing a FIN segment that does not
>>> contain data.  In such situations, TLP is unable to recover from
>>> *any* tail loss and instead adds at least PTO ms to the
>>> retransmission process, i.e., RTO = RTO + PTO.
>>>
>>> Signed-off-by: Per Hurtig <per.hurtig@kau.se>
>>> ---
>>>  net/ipv4/tcp_output.c | 4 +---
>>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>>
>>> diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
>>> index ad7549f..819bf0c 100644
>>> --- a/net/ipv4/tcp_output.c
>>> +++ b/net/ipv4/tcp_output.c
>>> @@ -2131,9 +2131,7 @@ void tcp_send_loss_probe(struct sock *sk)
>>>       if (WARN_ON(!skb || !tcp_skb_pcount(skb)))
>>>               goto rearm_timer;
>>>
>>> -     /* Probe with zero data doesn't trigger fast recovery. */
>>> -     if (skb->len > 0)
>>> -             err = __tcp_retransmit_skb(sk, skb);
>>> +     err = __tcp_retransmit_skb(sk, skb);
>>>
>>>       /* Record snd_nxt for loss detection. */
>>>       if (likely(!err))
>>
>> Thanks a lot Per
>>
>> Signed-off-by: Eric Dumazet <edumazet@google.com>
>
> Acked-by: Nandita Dukkipati <nanditad@google.com>

Thanks, Per!

Acked-by: Neal Cardwell <ncardwell@google.com>

neal