From: Neal Cardwell <ncardwell@google.com>
To: Eric Dumazet <edumazet@google.com>
Cc: David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
jean-louis@dupond.be, Yuchung Cheng <ycheng@google.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH v2 net-next 1/4] tcp: hint compiler about sack flows
Date: Tue, 27 Nov 2018 16:03:31 -0500 [thread overview]
Message-ID: <CADVnQynXM7rdTAaGPS1kG41b7L3PtMFULVMXdaDZZ1eG1=9Grg@mail.gmail.com> (raw)
In-Reply-To: <20181127155738.73068-2-edumazet@google.com>
On Tue, Nov 27, 2018 at 10:57 AM Eric Dumazet <edumazet@google.com> wrote:
>
> Tell the compiler that most TCP flows are using SACK these days.
>
> There is no need to add the unlikely() clause in tcp_is_reno(),
> the compiler is able to infer it.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
Acked-by: Neal Cardwell <ncardwell@google.com>
Nice. Thanks!
neal
next prev parent reply other threads:[~2018-11-28 8:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 15:57 [PATCH v2 net-next 0/4] tcp: take a bit more care of backlog stress Eric Dumazet
2018-11-27 15:57 ` [PATCH v2 net-next 1/4] tcp: hint compiler about sack flows Eric Dumazet
2018-11-27 21:03 ` Neal Cardwell [this message]
2018-11-27 15:57 ` [PATCH v2 net-next 2/4] tcp: take care of compressed acks in tcp_add_reno_sack() Eric Dumazet
2018-11-27 21:19 ` Neal Cardwell
2018-11-27 21:54 ` Eric Dumazet
2018-11-27 15:57 ` [PATCH v2 net-next 3/4] tcp: make tcp_space() aware of socket backlog Eric Dumazet
2018-11-27 21:22 ` Neal Cardwell
2018-11-27 15:57 ` [PATCH v2 net-next 4/4] tcp: implement coalescing on backlog queue Eric Dumazet
2018-11-27 21:58 ` Neal Cardwell
2018-11-27 22:13 ` Eric Dumazet
2018-11-27 22:32 ` Eric Dumazet
2018-11-27 17:50 ` [PATCH v2 net-next 0/4] tcp: take a bit more care of backlog stress Yuchung Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADVnQynXM7rdTAaGPS1kG41b7L3PtMFULVMXdaDZZ1eG1=9Grg@mail.gmail.com' \
--to=ncardwell@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jean-louis@dupond.be \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).