* 3.0.23 WARNING: at net/ipv4/tcp_input.c:3375 tcp_ack+0x1d62/0x2030()
@ 2012-03-19 8:10 Stefan Priebe - Profihost AG
2012-03-19 16:15 ` Greg KH
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Priebe - Profihost AG @ 2012-03-19 8:10 UTC (permalink / raw)
To: stable; +Cc: Linux Netdev List
Hi list,
today i've seen the following error / backtrace several times on a
machine running vanilla stable 3.0.23.
------------[ cut here ]------------
WARNING: at net/ipv4/tcp_input.c:3375 tcp_ack+0x1d62/0x2030()
Hardware name: empty
Modules linked in: xt_tcpudp ipt_REJECT iptable_filter ip_tables
x_tables k8temp ipv6 md_mod dm_snapshot dm_mod
Pid: 0, comm: swapper Tainted: G W 2.6.40.23intel #1
Call Trace:
[<c05de162>] ? tcp_ack+0x1d62/0x2030
[<c013d56c>] warn_slowpath_common+0x6c/0xa0
[<c05de162>] ? tcp_ack+0x1d62/0x2030
[<c0605e20>] ? bictcp_undo_cwnd+0x20/0x20
[<c013d5bd>] warn_slowpath_null+0x1d/0x20
[<c05de162>] tcp_ack+0x1d62/0x2030
[<c05daa09>] ? tcp_validate_incoming+0x269/0x330
[<c05de6d6>] tcp_rcv_established+0x2a6/0x5a0
[<c05e72d1>] tcp_v4_do_rcv+0xf1/0x250
[<c05e7a7a>] tcp_v4_rcv+0x64a/0x7b0
[<f874c0ab>] ? iptable_filter_hook+0x3b/0x74 [iptable_filter]
[<c05c809f>] ip_local_deliver_finish+0xef/0x260
[<c05c829f>] ip_local_deliver+0x8f/0xa0
[<c05c7fb0>] ? ip_call_ra_chain+0x110/0x110
[<c05c7973>] ip_rcv_finish+0x143/0x350
[<c05c7e1d>] ip_rcv+0x29d/0x320
[<c05e484e>] ? tcp4_gro_receive+0x4e/0xd0
[<c05a74cc>] __netif_receive_skb+0x37c/0x3f0
[<c05a8177>] netif_receive_skb+0x47/0x70
[<c05a829f>] napi_skb_finish+0x3f/0x50
[<c05a8f91>] napi_gro_receive+0x111/0x140
[<c04e61e7>] e1000_receive_skb+0x47/0x60
[<c04e7e56>] e1000_clean_rx_irq+0x1f6/0x370
[<c04e69f3>] e1000_clean+0x63/0x2b0
[<c05a874d>] net_rx_action+0xdd/0x230
[<c0143369>] __do_softirq+0xa9/0x180
[<c01432c0>] ? irq_enter+0x60/0x60
[<c01432c0>] ? irq_enter+0x60/0x60
<IRQ> [<c01431bd>] ? irq_exit+0x6d/0x90
[<c0104375>] ? do_IRQ+0x45/0xb0
[<c01431bd>] ? irq_exit+0x6d/0x90
[<c011bf09>] ? smp_apic_timer_interrupt+0x59/0x90
[<c065e9b0>] ? common_interrupt+0x30/0x38
[<c010aaee>] ? mwait_idle+0xee/0x100
[<c0101ee6>] ? cpu_idle+0x96/0xb0
[<c0638188>] ? rest_init+0x58/0x70
[<c08a08a5>] ? start_kernel+0x344/0x3a7
[<c08a0325>] ? kernel_init+0x13e/0x13e
[<c08a0079>] ? i386_start_kernel+0x79/0xb5
---[ end trace b310ee8f88560c3c ]---
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: 3.0.23 WARNING: at net/ipv4/tcp_input.c:3375 tcp_ack+0x1d62/0x2030()
2012-03-19 8:10 3.0.23 WARNING: at net/ipv4/tcp_input.c:3375 tcp_ack+0x1d62/0x2030() Stefan Priebe - Profihost AG
@ 2012-03-19 16:15 ` Greg KH
2012-03-19 16:16 ` Greg KH
0 siblings, 1 reply; 8+ messages in thread
From: Greg KH @ 2012-03-19 16:15 UTC (permalink / raw)
To: Stefan Priebe - Profihost AG; +Cc: stable, Linux Netdev List
On Mon, Mar 19, 2012 at 09:10:51AM +0100, Stefan Priebe - Profihost AG wrote:
> Hi list,
>
> today i've seen the following error / backtrace several times on a
> machine running vanilla stable 3.0.23.
Can you try 3.0.24?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: 3.0.23 WARNING: at net/ipv4/tcp_input.c:3375 tcp_ack+0x1d62/0x2030()
2012-03-19 16:15 ` Greg KH
@ 2012-03-19 16:16 ` Greg KH
2012-03-19 17:13 ` Eric Dumazet
0 siblings, 1 reply; 8+ messages in thread
From: Greg KH @ 2012-03-19 16:16 UTC (permalink / raw)
To: Stefan Priebe - Profihost AG; +Cc: stable, Linux Netdev List
On Mon, Mar 19, 2012 at 09:15:34AM -0700, Greg KH wrote:
> On Mon, Mar 19, 2012 at 09:10:51AM +0100, Stefan Priebe - Profihost AG wrote:
> > Hi list,
> >
> > today i've seen the following error / backtrace several times on a
> > machine running vanilla stable 3.0.23.
>
> Can you try 3.0.24?
That would be 3.0.25, sorry about that.
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: 3.0.23 WARNING: at net/ipv4/tcp_input.c:3375 tcp_ack+0x1d62/0x2030()
2012-03-19 16:16 ` Greg KH
@ 2012-03-19 17:13 ` Eric Dumazet
2012-03-19 17:39 ` Neal Cardwell
0 siblings, 1 reply; 8+ messages in thread
From: Eric Dumazet @ 2012-03-19 17:13 UTC (permalink / raw)
To: Greg KH; +Cc: Stefan Priebe - Profihost AG, stable, Linux Netdev List
On Mon, 2012-03-19 at 09:16 -0700, Greg KH wrote:
> On Mon, Mar 19, 2012 at 09:15:34AM -0700, Greg KH wrote:
> > On Mon, Mar 19, 2012 at 09:10:51AM +0100, Stefan Priebe - Profihost AG wrote:
> > > Hi list,
> > >
> > > today i've seen the following error / backtrace several times on a
> > > machine running vanilla stable 3.0.23.
> >
> > Can you try 3.0.24?
>
> That would be 3.0.25, sorry about that.
Yes, this includes the following fixes :
Neal Cardwell (3):
tcp: fix false reordering signal in tcp_shifted_skb
tcp: don't fragment SACKed skbs in tcp_mark_head_lost()
tcp: fix tcp_shift_skb_data() to not shift SACKed data below snd_una
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: 3.0.23 WARNING: at net/ipv4/tcp_input.c:3375 tcp_ack+0x1d62/0x2030()
2012-03-19 17:13 ` Eric Dumazet
@ 2012-03-19 17:39 ` Neal Cardwell
2012-03-19 18:20 ` Stefan Priebe
0 siblings, 1 reply; 8+ messages in thread
From: Neal Cardwell @ 2012-03-19 17:39 UTC (permalink / raw)
To: Eric Dumazet
Cc: Greg KH, Stefan Priebe - Profihost AG, stable, Linux Netdev List
On Mon, Mar 19, 2012 at 09:10:51AM +0100, Stefan Priebe - Profihost AG wrote:
> WARNING: at net/ipv4/tcp_input.c:3375 tcp_ack+0x1d62/0x2030()
I double-checked the warning, and indeed in the 3.0.23 tcp_input.c at
http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=blob;f=net/ipv4/tcp_input.c;h=ee08f11ff21a802faa8b32efc1eb312e479878d6;hb=bf6a68d2a214e07f7c0d6538e00e17b826714160#l3375
that line is:
WARN_ON((int)tp->sacked_out < 0);
So this indeed looks like the known issue that is fixed by the commits
Eric mentions, which are in 3.0.25.
neal
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: 3.0.23 WARNING: at net/ipv4/tcp_input.c:3375 tcp_ack+0x1d62/0x2030()
2012-03-19 17:39 ` Neal Cardwell
@ 2012-03-19 18:20 ` Stefan Priebe
2012-03-19 18:24 ` David Miller
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Priebe @ 2012-03-19 18:20 UTC (permalink / raw)
To: Neal Cardwell
Cc: Eric Dumazet, Greg KH, stable@vger.kernel.org, Linux Netdev List
Am 19.03.2012 um 18:39 schrieb Neal Cardwell <ncardwell@google.com>:
> On Mon, Mar 19, 2012 at 09:10:51AM +0100, Stefan Priebe - Profihost AG wrote:
>> WARNING: at net/ipv4/tcp_input.c:3375 tcp_ack+0x1d62/0x2030()
>
> I double-checked the warning, and indeed in the 3.0.23 tcp_input.c at
>
> http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=blob;f=net/ipv4/tcp_input.c;h=ee08f11ff21a802faa8b32efc1eb312e479878d6;hb=bf6a68d2a214e07f7c0d6538e00e17b826714160#l3375
>
> that line is:
> WARN_ON((int)tp->sacked_out < 0);
>
> So this indeed looks like the known issue that is fixed by the commits
> Eric mentions, which are in 3.0.25.
>
> neal
Perfect, thanks!
Greg any ETA?
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: 3.0.23 WARNING: at net/ipv4/tcp_input.c:3375 tcp_ack+0x1d62/0x2030()
2012-03-19 18:20 ` Stefan Priebe
@ 2012-03-19 18:24 ` David Miller
2012-03-20 7:30 ` Stefan Priebe - Profihost AG
0 siblings, 1 reply; 8+ messages in thread
From: David Miller @ 2012-03-19 18:24 UTC (permalink / raw)
To: s.priebe; +Cc: ncardwell, eric.dumazet, greg, stable, netdev
From: Stefan Priebe <s.priebe@profihost.ag>
Date: Mon, 19 Mar 2012 19:20:39 +0100
> Am 19.03.2012 um 18:39 schrieb Neal Cardwell <ncardwell@google.com>:
>
>> On Mon, Mar 19, 2012 at 09:10:51AM +0100, Stefan Priebe - Profihost AG wrote:
>>> WARNING: at net/ipv4/tcp_input.c:3375 tcp_ack+0x1d62/0x2030()
>>
>> I double-checked the warning, and indeed in the 3.0.23 tcp_input.c at
>>
>> http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=blob;f=net/ipv4/tcp_input.c;h=ee08f11ff21a802faa8b32efc1eb312e479878d6;hb=bf6a68d2a214e07f7c0d6538e00e17b826714160#l3375
>>
>> that line is:
>> WARN_ON((int)tp->sacked_out < 0);
>>
>> So this indeed looks like the known issue that is fixed by the commits
>> Eric mentions, which are in 3.0.25.
>>
>> neal
>
> Perfect, thanks!
>
> Greg any ETA?
He released it the very second he told you to use it.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: 3.0.23 WARNING: at net/ipv4/tcp_input.c:3375 tcp_ack+0x1d62/0x2030()
2012-03-19 18:24 ` David Miller
@ 2012-03-20 7:30 ` Stefan Priebe - Profihost AG
0 siblings, 0 replies; 8+ messages in thread
From: Stefan Priebe - Profihost AG @ 2012-03-20 7:30 UTC (permalink / raw)
To: David Miller; +Cc: ncardwell, eric.dumazet, greg, stable, netdev
Am 19.03.2012 19:24, schrieb David Miller:
>> Perfect, thanks!
>>
>> Greg any ETA?
>
> He released it the very second he told you to use it.
Thanks - Greg is just too fast for me ;-)
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-03-20 7:30 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-19 8:10 3.0.23 WARNING: at net/ipv4/tcp_input.c:3375 tcp_ack+0x1d62/0x2030() Stefan Priebe - Profihost AG
2012-03-19 16:15 ` Greg KH
2012-03-19 16:16 ` Greg KH
2012-03-19 17:13 ` Eric Dumazet
2012-03-19 17:39 ` Neal Cardwell
2012-03-19 18:20 ` Stefan Priebe
2012-03-19 18:24 ` David Miller
2012-03-20 7:30 ` Stefan Priebe - Profihost AG
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).