From: lucien xin <lucien.xin@gmail.com>
To: Vlad Yasevich <vyasevic@redhat.com>
Cc: network dev <netdev@vger.kernel.org>,
Marcelo Ricardo Leitner <mleitner@redhat.com>,
daniel@iogearbox.net, davem <davem@davemloft.net>
Subject: Re: [PATCH net] sctp: support global vtag assochash and per endpoint s(d)port assochash table
Date: Wed, 2 Sep 2015 04:11:44 +0800 [thread overview]
Message-ID: <CADvbK_cLgw3xnnT2_ENZgaFTWncpoKNF2bazBWuX152ZSLUG4w@mail.gmail.com> (raw)
In-Reply-To: <55E4E89A.8060508@redhat.com>
>
> In addition to what David said and looking at it from a different angle... 256 buckets
> may not be enough for someone with a single endpoint and alot of associations. You
> will still hit a long chain on INIT and COOKIE-ECHO chunks.
>
> Switching to using rhashtable for association hash would be very nice.
>
good idea, I will think about it.
> Also, see if you can split this into 2 parts, one that does vtag hash and
> the other is refactoring. It would make it much easier to review.
>
I tried, it's kind of hard, cause i do not add the vtag hashtable, but
change the
original hashtable to vtag hashtable, which make sendmsg lost its hashtable.
I have to add another one for per endpoint.
anyway, I will try to split it again, thanks.
> -vlad
>
next prev parent reply other threads:[~2015-09-01 20:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 17:44 [PATCH net] sctp: support global vtag assochash and per endpoint s(d)port assochash table Xin Long
2015-08-31 17:48 ` lucien xin
2015-08-31 18:11 ` lucien xin
2015-08-31 22:16 ` David Miller
2015-09-01 20:03 ` lucien xin
2015-08-31 23:51 ` Vlad Yasevich
2015-09-01 20:11 ` lucien xin [this message]
2015-09-01 14:53 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADvbK_cLgw3xnnT2_ENZgaFTWncpoKNF2bazBWuX152ZSLUG4w@mail.gmail.com \
--to=lucien.xin@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).