From: Xin Long <lucien.xin@gmail.com>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
linux-sctp@vger.kernel.org, Neil Horman <nhorman@tuxdriver.com>,
Vlad Yasevich <vyasevich@gmail.com>
Subject: Re: [PATCH net] sctp: removed unused var from sctp_make_auth
Date: Sat, 13 Jan 2018 12:50:34 +0800 [thread overview]
Message-ID: <CADvbK_cS2O9WEuSKkjSKGUxheCv6phooWQHpXrrQGsiZNMtWPg@mail.gmail.com> (raw)
In-Reply-To: <a3ff9e23cd1c4c040c76b80196d1c3b99fe22bb6.1515687693.git.marcelo.leitner@gmail.com>
On Fri, Jan 12, 2018 at 12:22 AM, Marcelo Ricardo Leitner
<marcelo.leitner@gmail.com> wrote:
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> ---
> net/sctp/sm_make_chunk.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
> index 9bf575f2e8ed0888e0219a872e84018ada5064e0..f08531de5682256064ce35e3d44200caa71c3db8 100644
> --- a/net/sctp/sm_make_chunk.c
> +++ b/net/sctp/sm_make_chunk.c
> @@ -1273,7 +1273,6 @@ struct sctp_chunk *sctp_make_auth(const struct sctp_association *asoc)
> struct sctp_authhdr auth_hdr;
> struct sctp_hmac *hmac_desc;
> struct sctp_chunk *retval;
> - __u8 *hmac;
>
> /* Get the first hmac that the peer told us to use */
> hmac_desc = sctp_auth_asoc_get_hmac(asoc);
> @@ -1292,7 +1291,7 @@ struct sctp_chunk *sctp_make_auth(const struct sctp_association *asoc)
> retval->subh.auth_hdr = sctp_addto_chunk(retval, sizeof(auth_hdr),
> &auth_hdr);
>
> - hmac = skb_put_zero(retval->skb, hmac_desc->hmac_len);
> + skb_put_zero(retval->skb, hmac_desc->hmac_len);
>
> /* Adjust the chunk header to include the empty MAC */
> retval->chunk_hdr->length =
> --
> 2.14.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Xin Long <lucien.xin@gmail.com>
next prev parent reply other threads:[~2018-01-13 4:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 16:22 [PATCH net] sctp: removed unused var from sctp_make_auth Marcelo Ricardo Leitner
2018-01-12 20:16 ` Neil Horman
2018-01-13 4:50 ` Xin Long [this message]
2018-01-15 19:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADvbK_cS2O9WEuSKkjSKGUxheCv6phooWQHpXrrQGsiZNMtWPg@mail.gmail.com \
--to=lucien.xin@gmail.com \
--cc=linux-sctp@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).