netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: lucien xin <lucien.xin@gmail.com>
To: Xin Long <lucien.xin@gmail.com>, network dev <netdev@vger.kernel.org>
Subject: Re: [PATCH] ip_tunnel:multicast process cause panic due to skb->_skb_refdst NULL pointer
Date: Fri, 28 Feb 2014 09:27:35 +0800	[thread overview]
Message-ID: <CADvbK_d+B2sRCZ-aBDUz3808os2C2gvdJsQQO6_FNs7djQA9kQ@mail.gmail.com> (raw)
In-Reply-To: <20140224145807.GG6598@order.stressinduktion.org>

On Mon, Feb 24, 2014 at 10:58 PM, Hannes Frederic Sowa
<hannes@stressinduktion.org> wrote:
>
> If the packet is locally forwarded we can test for IPCB(skb)->flags &
> IPSKB_FORWARDED.
>

thanks for  your reply,  hannes

IPSKB_FORWARDED is locally forwarded flag, but in ip_tunnel_rcv(), it
check if the packet
is a *looped back packet* (not about locally forwarded), the path is
__ip_route_output_key()-->
__mkroute_output()(rth->dst.output = ip_mc_output), then,
ip_mc_output()-->dev_loopback_xmit(),
 which happen when inet_sk(sk)->mc_loop =1, and in __mkroute_output(),
rth->rt_is_input = 0.
 In that path, IPCB(skb)->flags &IPSKB_FORWARDED always 0.

so I think 'IPCB(skb)->flags &IPSKB_FORWARDED' cannot meet the goal.

  reply	other threads:[~2014-02-28  1:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-24  4:35 [PATCH] ip_tunnel:multicast process cause panic due to skb->_skb_refdst NULL pointer Xin Long
2014-02-24 14:58 ` Hannes Frederic Sowa
2014-02-28  1:27   ` lucien xin [this message]
2014-03-01 17:33     ` Hannes Frederic Sowa
  -- strict thread matches above, loose matches on Subject: below --
2014-03-03 12:18 Xin Long
2014-03-03 20:57 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADvbK_d+B2sRCZ-aBDUz3808os2C2gvdJsQQO6_FNs7djQA9kQ@mail.gmail.com \
    --to=lucien.xin@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).