From: lucien xin <lucien.xin@gmail.com>
To: Cong Wang <cwang@twopensource.com>
Cc: network dev <netdev@vger.kernel.org>
Subject: Re: [PATCH] return the right retcode when add a unreachable route
Date: Wed, 9 Jul 2014 09:51:02 +0800 [thread overview]
Message-ID: <CADvbK_fBvG9WSMRWifJRUr6p-OQsZJL+MXC8LdDSbTEW8uSS4w@mail.gmail.com> (raw)
In-Reply-To: <CAHA+R7OgTOCASmT03H37KKobb6m0hs3amF7GNWLy=JRLW+2dew@mail.gmail.com>
On Wed, Jul 9, 2014 at 2:49 AM, Cong Wang <cwang@twopensource.com> wrote:
> On Sun, Jul 6, 2014 at 4:01 AM, Xin Long <lucien.xin@gmail.com> wrote:
>
> This would potentially break user-space applications.
yes, you are right. if I only handle the -ESRCH , like:
- return __fib_lookup(net, flp, res);
+
+ err = __fib_lookup(net, flp, res);
+ if(err == -ESRCH)
+ return -ENETUNREACH;
+
+ return err;
I think it will be ok, after all, it looks confused that err is *No
such process* when add a route.
thanks for your reply.
next prev parent reply other threads:[~2014-07-09 1:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-06 11:01 [PATCH] return the right retcode when add a unreachable route Xin Long
2014-07-08 18:49 ` Cong Wang
2014-07-09 1:51 ` lucien xin [this message]
2014-07-09 2:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADvbK_fBvG9WSMRWifJRUr6p-OQsZJL+MXC8LdDSbTEW8uSS4w@mail.gmail.com \
--to=lucien.xin@gmail.com \
--cc=cwang@twopensource.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).