From: Xin Long <lucien.xin@gmail.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: network dev <netdev@vger.kernel.org>,
linux-sctp@vger.kernel.org, davem <davem@davemloft.net>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Vlad Yasevich <vyasevich@gmail.com>,
daniel@iogearbox.net
Subject: Re: [PATCH net 2/5] sctp: reuse sent_count to avoid retransmitted chunks for RTT measurements
Date: Tue, 27 Sep 2016 17:54:07 +0800 [thread overview]
Message-ID: <CADvbK_fFkn1PcRnRg2PJnCEnhLfojSHp+LCKCWWwxM_xi-fJfQ@mail.gmail.com> (raw)
In-Reply-To: <20160926131300.GA6812@hmsreliant.think-freely.org>
>
> Maybe wrap this in a macro? i.e.:
> #define chunk_retransmitted(chunk) (chunk->sent_count > 1)
>
> For readability?
>
That's a nice suggestion.
chunk->sent_count == 1 is confusing there for reading.
will improve it in v2.
Thanks.
prev parent reply other threads:[~2016-09-27 9:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 9:47 [PATCH net 0/5] sctp: some fixes of prsctp polices Xin Long
2016-09-26 9:47 ` [PATCH net 1/5] sctp: move sent_count to the memory hole in sctp_chunk Xin Long
2016-09-26 9:47 ` [PATCH net 2/5] sctp: reuse sent_count to avoid retransmitted chunks for RTT measurements Xin Long
2016-09-26 9:47 ` [PATCH net 3/5] sctp: remove prsctp_param from sctp_chunk Xin Long
2016-09-26 9:47 ` [PATCH net 4/5] sctp: change to check peer prsctp_capable when using prsctp polices Xin Long
2016-09-26 9:47 ` [PATCH net 5/5] sctp: remove the old ttl expires policy Xin Long
2016-09-26 13:13 ` [PATCH net 2/5] sctp: reuse sent_count to avoid retransmitted chunks for RTT measurements Neil Horman
2016-09-27 9:54 ` Xin Long [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADvbK_fFkn1PcRnRg2PJnCEnhLfojSHp+LCKCWWwxM_xi-fJfQ@mail.gmail.com \
--to=lucien.xin@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).