netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: lucien xin <lucien.xin@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: David Miller <davem@davemloft.net>, network dev <netdev@vger.kernel.org>
Subject: Re: [PATCH] vxlan: using AF_PACKET socket to send multicast packet cause WARNING
Date: Thu, 3 Apr 2014 13:28:33 +0800	[thread overview]
Message-ID: <CADvbK_ftDf_AsbEeF9EViBm68Co3bj1L-fR1-BDA0Uxn=1LPpA@mail.gmail.com> (raw)
In-Reply-To: <20140402075106.3eec7791@nehalam.linuxnetplumber.net>

On Wed, Apr 2, 2014 at 10:51 PM, Stephen Hemminger
<stephen@networkplumber.org> wrote:
> That breaks local socket accounting for tunneled packets.
It do break, I think it should break, becaue vlxan send UDP packets,
it should be bound to UDP socket.
after  encapsulating the packet with local socket.  it reach the
vxlan's xmit.  and It should be take into
vxlan's UDP socket.and local socket should not take care of it.

now the problem is that the local socket(AF_PACKET) cannot take it to
travel the ipv4/6 protocol stack,
unlike TCP/UDP socket.   perhaps, in later, there will be other type
protocol family that has the same issue.
so I think vxlan should support it.

> The idea is that a TCP socket sending over vxlan will keep it's
> memory accounting all the way until the device sends it.
yes, the idea is there.  But if vxlan is treated as net_device,  the
packet enter it's xmit(), which seems
 to be send by the device.  so when the packet goes there, the TCP
socket also should let it go.

of course, if you insist the idea you said,  to support only some type
protocol family, do you have some
better suggestion?

I cannot be sure I understand you well, those are just my own
thoughts. pls help to check and correct it .  :)

many thanks to your reply.

  reply	other threads:[~2014-04-03  5:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-01  9:08 [PATCH] vxlan: using AF_PACKET socket to send multicast packet cause WARNING Xin Long
2014-04-01 20:10 ` David Miller
2014-04-02  5:31   ` lucien xin
2014-04-02 14:51     ` Stephen Hemminger
2014-04-03  5:28       ` lucien xin [this message]
2014-04-03 16:48         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADvbK_ftDf_AsbEeF9EViBm68Co3bj1L-fR1-BDA0Uxn=1LPpA@mail.gmail.com' \
    --to=lucien.xin@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).