From: Menglong Dong <menglong8.dong@gmail.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: kuba@kernel.org, ojeda@kernel.org, ndesaulniers@google.com,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
asml.silence@gmail.com, imagedong@tencent.com,
luiz.von.dentz@intel.com, vasily.averin@linux.dev,
jk@codeconstruct.com.au, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH net-next v4] net: skb: prevent the split of kfree_skb_reason() by gcc
Date: Wed, 17 Aug 2022 10:20:14 +0800 [thread overview]
Message-ID: <CADxym3Y1ZoWrkGW3v4PbVMvbEYnoFgHmFXCD-QpY4Of9hrAxBg@mail.gmail.com> (raw)
In-Reply-To: <CANiq72mQpZ-z1vVeOwdaOB3b=jjQHtPwz3-jaPRV330-yL_FqQ@mail.gmail.com>
On Tue, Aug 16, 2022 at 5:02 PM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Tue, Aug 16, 2022 at 5:29 AM <menglong8.dong@gmail.com> wrote:
> >
> > Reported-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
>
> Hmm... Why did you add me as a reporter?
>
Enn...because you pointed out my code's problem, just like what robot do.
Shouldn't I?
> > + * Optional: not supported by clang.
> > + * Optional: not supported by icc.
>
> Much better, thank you! Please add the links to GCC's docs, like in
> most attributes (some newer attributes may have been added without
> them -- I will fix that).
>
> In any case, no need to send a new version just for this for the
> moment, I would recommend waiting until others comment on whether they
> want `__optimize__` used here as the workaround.
>
Okay, I'll wait longer before the next version.
Thanks!
Menglong Dong
> Cheers,
> Miguel
next prev parent reply other threads:[~2022-08-17 2:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 3:28 [PATCH net-next v4] net: skb: prevent the split of kfree_skb_reason() by gcc menglong8.dong
2022-08-16 9:02 ` Miguel Ojeda
2022-08-17 2:20 ` Menglong Dong [this message]
2022-08-17 5:54 ` Miguel Ojeda
2022-08-17 15:54 ` Nick Desaulniers
2022-08-18 16:31 ` Menglong Dong
2022-08-18 16:58 ` Segher Boessenkool
2022-08-19 14:55 ` Menglong Dong
2022-08-19 15:21 ` Segher Boessenkool
2022-08-20 11:00 ` Menglong Dong
2022-08-22 8:01 ` Florian Weimer
2022-08-23 16:23 ` Menglong Dong
2022-09-06 12:37 ` Florian Weimer
2022-09-06 15:30 ` Segher Boessenkool
2022-09-07 18:59 ` Florian Weimer
2022-09-07 19:47 ` Segher Boessenkool
2022-08-18 17:09 ` Jakub Kicinski
2022-08-19 15:17 ` Menglong Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADxym3Y1ZoWrkGW3v4PbVMvbEYnoFgHmFXCD-QpY4Of9hrAxBg@mail.gmail.com \
--to=menglong8.dong@gmail.com \
--cc=asml.silence@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imagedong@tencent.com \
--cc=jk@codeconstruct.com.au \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=luiz.von.dentz@intel.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=pabeni@redhat.com \
--cc=vasily.averin@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).