netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Menglong Dong <menglong8.dong@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: edumazet@google.com, ncardwell@google.com, davem@davemloft.net,
	 kuba@kernel.org, pabeni@redhat.com, corbet@lwn.net,
	dsahern@kernel.org,  kuniyu@amazon.com, morleyd@google.com,
	imagedong@tencent.com,  mfreemon@cloudflare.com,
	mubashirq@google.com, netdev@vger.kernel.org,
	 linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: tcp: support to probe tcp receiver OOM
Date: Fri, 14 Jul 2023 17:56:03 +0800	[thread overview]
Message-ID: <CADxym3Y2f6-FfyG3RfvPDXLS3b3FqUfxaDPgju6OoQPy-0i9bQ@mail.gmail.com> (raw)
In-Reply-To: <04a96ba2-6952-e6de-93a2-dc2998ce519d@infradead.org>

On Thu, Jul 13, 2023 at 11:43 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
>
>
> On 7/13/23 04:24, menglong8.dong@gmail.com wrote:
> > diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst
> > index 4a010a7cde7f..3de2dce74037 100644
> > --- a/Documentation/networking/ip-sysctl.rst
> > +++ b/Documentation/networking/ip-sysctl.rst
> > @@ -694,6 +694,20 @@ tcp_retries2 - INTEGER
> >       RFC 1122 recommends at least 100 seconds for the timeout,
> >       which corresponds to a value of at least 8.
> >
> > +tcp_oom_retries - INTEGER
> > +     RTO retransmissions count of the receiver is recognised as OOM.
> > +     Given a value N, a hypothetical TCP connection will enter probe
> > +     state if N times RTO retransmissions performed and every
> > +     retransmission gets a pure ack, who doesn't contain SACK block.
>
>                                    ACK
> > +
> > +     The default value is 0, which means disable the OOM detection.
> > +     If disabled, skb will be dropped directly, without sending an
> > +     ACK, when rmem schedule fails. The function is valid only if sack
>
>                                                                      SACK
>
> > +     is enabled.
> > +
> > +     3 is the suggested value to enable this function. Do't make it
>
>                                                           Don't
>
> > +     greater than tcp_retries2.
>

Thanks! I'll fix them in the next version.

> --
> ~Randy

  reply	other threads:[~2023-07-14  9:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-13 11:24 [PATCH net-next v2] net: tcp: support to probe tcp receiver OOM menglong8.dong
2023-07-13 15:42 ` Randy Dunlap
2023-07-14  9:56   ` Menglong Dong [this message]
2023-07-17 16:46 ` Eric Dumazet
2023-07-19 12:35   ` Menglong Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADxym3Y2f6-FfyG3RfvPDXLS3b3FqUfxaDPgju6OoQPy-0i9bQ@mail.gmail.com \
    --to=menglong8.dong@gmail.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=imagedong@tencent.com \
    --cc=kuba@kernel.org \
    --cc=kuniyu@amazon.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mfreemon@cloudflare.com \
    --cc=morleyd@google.com \
    --cc=mubashirq@google.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).