From: Amy Parker <enbyamy@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, Andrew Morton <akpm@linux-foundation.org>,
rppt@kernel.org, netdev@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] drivers/net/ethernet/amd: Follow style guide
Date: Sun, 7 Feb 2021 12:48:57 -0800 [thread overview]
Message-ID: <CAE1WUT7T8C6XSgAAqTcmK5Syy16Hi90VSLfspZyeMO8T3Jmaqw@mail.gmail.com> (raw)
In-Reply-To: <20210206120751.30e175a4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Sat, Feb 6, 2021 at 12:07 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Fri, 5 Feb 2021 16:01:43 -0800 Amy Parker wrote:
> > This patchset updates atarilance.c and sun3lance.c to follow the kernel
> > style guide. Each patch tackles a different issue in the style guide.
>
> These are very, very old drivers, nobody worked on them for a decade.
> What's your motivation for making these changes?
I've just been trying to make patches to clean up code to follow the
style guide. These files had a lot of violations.
prev parent reply other threads:[~2021-02-07 20:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-06 0:01 [PATCH 0/3] drivers/net/ethernet/amd: Follow style guide Amy Parker
2021-02-06 0:01 ` [PATCH 1/3] drivers/net/ethernet/amd: Correct spacing around C keywords Amy Parker
2021-02-06 0:01 ` [PATCH 2/3] drivers/net/ethernet/amd: Fix bracket matching and line levels Amy Parker
2021-02-06 0:01 ` [PATCH 3/3] drivers/net/ethernet/amd: Break apart one-lined expressions Amy Parker
2021-02-06 3:16 ` [PATCH 0/3] drivers/net/ethernet/amd: Follow style guide Randy Dunlap
2021-02-06 4:28 ` Amy Parker
2021-02-06 20:07 ` Jakub Kicinski
2021-02-07 20:48 ` Amy Parker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE1WUT7T8C6XSgAAqTcmK5Syy16Hi90VSLfspZyeMO8T3Jmaqw@mail.gmail.com \
--to=enbyamy@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).