From mboxrd@z Thu Jan 1 00:00:00 1970 From: Veaceslav Falico Subject: Re: [PATCH v2 net-next 08/27] bonding: remove bond_for_each_slave_reverse() Date: Wed, 11 Sep 2013 07:39:43 +0200 Message-ID: References: <1378846691-9717-1-git-send-email-vfalico@redhat.com> <1378846691-9717-9-git-send-email-vfalico@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: netdev To: Cong Wang Return-path: Received: from mail-pa0-f47.google.com ([209.85.220.47]:55608 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751843Ab3IKFkE (ORCPT ); Wed, 11 Sep 2013 01:40:04 -0400 Received: by mail-pa0-f47.google.com with SMTP id kl13so8772633pab.34 for ; Tue, 10 Sep 2013 22:40:03 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Sep 11, 2013 at 3:53 AM, Cong Wang wrote: > On Tue, 10 Sep 2013 at 20:57 GMT, Veaceslav Falico wrote: >> We only use it in rollback scenarios and can easily use the standart >> bond_for_each_dev() instead. >> > > What you remove actually is bond_for_each_slave_continue_reverse()... > $subject needs to be fixed. Indeed, thank you, will fix :). > > >> diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c >> index c3dcc6b..46f6b40 100644 >> --- a/drivers/net/bonding/bond_alb.c >> +++ b/drivers/net/bonding/bond_alb.c >> @@ -1246,9 +1246,9 @@ static int alb_handle_addr_collision_on_attach(struct bonding *bond, struct slav >> */ >> static int alb_set_mac_address(struct bonding *bond, void *addr) >> { >> - char tmp_addr[ETH_ALEN]; >> - struct slave *slave; >> + struct slave *slave, *rollback_slave; >> struct sockaddr sa; >> + char tmp_addr[ETH_ALEN]; > > Why are you moving tmp_addr[]? It's more readable, IMO, if structs go first. -- Best regards, Veaceslav Falico