From: Scott Feldman <sfeldma@gmail.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Netdev <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Jiří Pírko" <jiri@resnulli.us>,
"Roopa Prabhu" <roopa@cumulusnetworks.com>,
"alexander.h.duyck@redhat.com" <alexander.h.duyck@redhat.com>
Subject: Re: [PATCH net-next v4 2/8] netdevice: add IPv4 fib add/del ops
Date: Mon, 9 Mar 2015 11:07:44 -0700 [thread overview]
Message-ID: <CAE4R7bBMcSf3VO9bBpa5Fxus0FSk5S2akSCYX0HYGV3K+ixACQ@mail.gmail.com> (raw)
In-Reply-To: <54FDA458.6040601@mojatatu.com>
On Mon, Mar 9, 2015 at 6:47 AM, Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> On 03/06/15 14:59, Scott Feldman wrote:
>>
>>
>> I considered passing netlink flags in to driver, but the kernel logic
>> in fib_table_insert() already takes care of the checks required by the
>> flags, and from the driver's perspective, only three ops are needed:
>> add, del, and mod. And I've combined add and mod into the same op,
>> with the assumption the driver can know if an entry exists or not.
>>
>
> That assumption is not accurate. At least in some hardware i am working
> on right now a mod is cheaper than a create (and if i have to "know"
> wheter i should create or modify then i actually i have to query the
> hardware).
Good points Jamal (and Roopa), thanks for reviewing. I'll send update
to pass in NLM_F_* flags.
next prev parent reply other threads:[~2015-03-09 18:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 5:21 [PATCH net-next v4 0/8] switchdev: add IPv4 routing offload sfeldma
2015-03-06 5:21 ` [PATCH net-next v4 1/8] rtnetlink: add RTNH_F_EXTERNAL flag for fib offload sfeldma
2015-03-06 5:21 ` [PATCH net-next v4 2/8] netdevice: add IPv4 fib add/del ops sfeldma
2015-03-06 14:55 ` Jamal Hadi Salim
2015-03-06 19:59 ` Scott Feldman
2015-03-08 14:31 ` roopa
2015-03-08 22:16 ` Scott Feldman
2015-03-09 6:22 ` roopa
2015-03-09 8:38 ` Scott Feldman
2015-03-09 13:47 ` Jamal Hadi Salim
2015-03-09 18:07 ` Scott Feldman [this message]
2015-03-06 5:21 ` [PATCH net-next v4 3/8] switchdev: add IPv4 fib ndo ops wrappers sfeldma
2015-03-06 5:21 ` [PATCH net-next v4 4/8] switchdev: don't support custom ip rules, for now sfeldma
2015-03-06 5:21 ` [PATCH net-next v4 5/8] switchdev: implement IPv4 fib ndo wrappers sfeldma
2015-03-06 7:24 ` Jiri Pirko
2015-03-06 9:38 ` Scott Feldman
2015-03-06 11:53 ` Jiri Pirko
2015-03-06 5:21 ` [PATCH net-next v4 6/8] ipv4: add net bool fib_offload_disabled sfeldma
2015-03-06 5:21 ` [PATCH net-next v4 7/8] fib: hook IPv4 fib for hardware offload sfeldma
2015-03-06 5:21 ` [PATCH net-next v4 8/8] rocker: implement IPv4 fib offloading sfeldma
2015-03-06 5:27 ` [PATCH net-next v4 0/8] switchdev: add IPv4 routing offload David Miller
2015-03-06 15:43 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE4R7bBMcSf3VO9bBpa5Fxus0FSk5S2akSCYX0HYGV3K+ixACQ@mail.gmail.com \
--to=sfeldma@gmail.com \
--cc=alexander.h.duyck@redhat.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).