From: Scott Feldman <sfeldma@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Netdev <netdev@vger.kernel.org>,
Roopa Prabhu <roopa@cumulusnetworks.com>
Subject: Re: [PATCH net-next 0/5] switchdev: add swdev ops
Date: Sun, 15 Mar 2015 10:56:34 -0700 [thread overview]
Message-ID: <CAE4R7bCfzhmWznFQ_JsUfidCKbuT-rppjXRqpgOcd7uqw1h5FQ@mail.gmail.com> (raw)
In-Reply-To: <20150315170355.GJ2043@nanopsycho.orion>
On Sun, Mar 15, 2015 at 10:03 AM, Jiri Pirko <jiri@resnulli.us> wrote:
> Sun, Mar 15, 2015 at 07:15:02AM CET, sfeldma@gmail.com wrote:
>>From: Scott Feldman <sfeldma@gmail.com>
>>
>>Per discussions at netconf, move switchdev ndo ops to a new swdev_ops to
>>keep ndo namespace clean and maintain switchdev-related ops into one place.
>>
>>There are no functional changes here; just shuffling ops around for better
>>organization.
>
> Hmm, I'm not sure this is the right approach. I think we do not need
> only switchdev ops to be pushed out. There are many more ndos that could
> be pushed out as well. What I'm thinking about is some more generic ndo
> struct partitioning. Have to think about the actual implementation some more.
I couldn't see a way to make a more generic ndo struct without casting
args to void * and back, or using a big overlay union. I may be
missing your idea; interested in what you come up with.
In the meantime, can we go with this simple partitioning?
-scott
next prev parent reply other threads:[~2015-03-15 17:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-15 6:15 [PATCH net-next 0/5] switchdev: add swdev ops sfeldma
2015-03-15 6:15 ` [PATCH net-next 1/5] " sfeldma
2015-03-15 6:15 ` [PATCH net-next 2/5] switchdev: use new " sfeldma
2015-03-15 23:44 ` Simon Horman
2015-03-16 0:43 ` Scott Feldman
2015-03-16 8:10 ` Simon Horman
2015-03-15 6:15 ` [PATCH net-next 3/5] rocker: move to " sfeldma
2015-03-15 6:15 ` [PATCH net-next 4/5] dsa: " sfeldma
2015-03-15 6:15 ` [PATCH net-next 5/5] netdev: remove ndo ops for switchdev sfeldma
2015-03-15 17:03 ` [PATCH net-next 0/5] switchdev: add swdev ops Jiri Pirko
2015-03-15 17:56 ` Scott Feldman [this message]
2015-03-16 0:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE4R7bCfzhmWznFQ_JsUfidCKbuT-rppjXRqpgOcd7uqw1h5FQ@mail.gmail.com \
--to=sfeldma@gmail.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).