From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhi Yong Wu Subject: Re: [net-next PATCH 3/6] macvtap: remove the dead branch Date: Fri, 6 Dec 2013 14:11:35 +0800 Message-ID: References: <1386282527-14094-1-git-send-email-zwu.kernel@gmail.com> <1386282527-14094-4-git-send-email-zwu.kernel@gmail.com> <52A169D4.4060209@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: netdev@vger.kernel.org, linux-kernel mlist , Zhi Yong Wu To: Guenter Roeck Return-path: In-Reply-To: <52A169D4.4060209@roeck-us.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, Dec 6, 2013 at 2:08 PM, Guenter Roeck wrote: > On 12/05/2013 02:28 PM, Zhi Yong Wu wrote: >> >> From: Zhi Yong Wu >> >> Signed-off-by: Zhi Yong Wu >> --- >> drivers/net/macvtap.c | 2 -- >> 1 files changed, 0 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c >> index 9093004..d271fb4 100644 >> --- a/drivers/net/macvtap.c >> +++ b/drivers/net/macvtap.c >> @@ -779,8 +779,6 @@ static ssize_t macvtap_put_user(struct macvtap_queue >> *q, >> return -EINVAL; >> >> ret = macvtap_skb_to_vnet_hdr(skb, &vnet_hdr); >> - if (ret) >> - return ret; >> > Assigning the function's return value to ret just to ignore it seems odd. > > Might make sense to change the function type to void. Yes, this is done in the next patch of this series. > > Guenter > -- Regards, Zhi Yong Wu