From: Jesse Gross <jesse@nicira.com>
To: Thomas Graf <tgraf@suug.ch>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Du, Fan" <fan.du@intel.com>, Jason Wang <jasowang@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"fw@strlen.de" <fw@strlen.de>,
"dev@openvswitch.org" <dev@openvswitch.org>,
Pravin Shelar <pshelar@nicira.com>
Subject: Re: [PATCH net] gso: do GSO for local skb with size bigger than MTU
Date: Wed, 3 Dec 2014 17:51:43 -0800 [thread overview]
Message-ID: <CAEP_g=8U_w+dxUHsTH2JQ9dGNHaJp-ai8pdmrfeYBin9NZ46jQ@mail.gmail.com> (raw)
In-Reply-To: <20141204011515.GA15666@casper.infradead.org>
On Wed, Dec 3, 2014 at 5:15 PM, Thomas Graf <tgraf@suug.ch> wrote:
> On 12/03/14 at 04:54pm, Jesse Gross wrote:
>> I don't think that we actually need a bit. I would expect that ICMP
>> generation to be coupled with routing (although this requires being
>> able to know what the ultimate MTU is at the time of routing the inner
>> packet). If that's the case, you just need to steer between L2 and L3
>> processing in the same way that you would today and ICMP would just
>> come in the right cases.
>
> I think the MTU awareness is solveable but how do you steer between
> L2 and L3? How do you differentiate between an L3 ACL rule in L2 mode
> and an actual L3 based forward? dec_ttl? This is what drove me to
> the user controlled bit and it became appealing as it allows to
> enable/disable PMTU per guest or even per flow/route.
I think it depends on where you put the PMTU check. If routing is
happening in OVS where it is decomposed in several discrete actions
like set MAC and decrement TTL then perhaps there is another explicit
action to check the MTU. If it is happening in the context of the IP
stack, then ICMP generation occurs automatically and if you get that
if you write a flow to send a packet there. In each case, it seems
like a flow would be steering you by way of an action to do routing so
you would have fine grained control. I don't see this as conflicting
with L3 ACLs in an L2 context in the same way that you don't have to
automatically decrement the TTL.
next prev parent reply other threads:[~2014-12-04 1:52 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 6:33 [PATCH net] gso: do GSO for local skb with size bigger than MTU Fan Du
2014-11-28 7:02 ` Jason Wang
2014-11-30 10:08 ` Du, Fan
2014-12-01 13:52 ` Thomas Graf
[not found] ` <20141201135225.GA16814-FZi0V3Vbi30CUdFEqe4BF2D2FQJk+8+b@public.gmane.org>
2014-12-01 15:06 ` Michael S. Tsirkin
2014-12-02 15:48 ` Flavio Leitner
2014-12-02 17:09 ` Thomas Graf
[not found] ` <20141202170927.GA9457-FZi0V3Vbi30CUdFEqe4BF2D2FQJk+8+b@public.gmane.org>
2014-12-02 17:34 ` Michael S. Tsirkin
2014-12-02 17:41 ` Thomas Graf
2014-12-02 18:12 ` Jesse Gross
[not found] ` <CAEP_g=-86Z6pxNow-wjnbx_v9er_TSn6x5waigqVqYHa7tEQJw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-03 9:03 ` Michael S. Tsirkin
2014-12-03 18:07 ` Jesse Gross
[not found] ` <CAEP_g=9C+D3gbjJ4n1t6xuyjqEAMYi4ZfqPoe92UAoQJH-UsKg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-03 18:38 ` Michael S. Tsirkin
2014-12-03 18:56 ` Rick Jones
[not found] ` <547F5CC2.8000908-VXdhtT5mjnY@public.gmane.org>
2014-12-04 10:17 ` Michael S. Tsirkin
2014-12-03 19:38 ` Jesse Gross
2014-12-03 22:02 ` Thomas Graf
[not found] ` <20141203220244.GA8822-FZi0V3Vbi30CUdFEqe4BF2D2FQJk+8+b@public.gmane.org>
2014-12-03 22:50 ` Michael S. Tsirkin
2014-12-03 22:51 ` Jesse Gross
2014-12-03 23:05 ` Thomas Graf
[not found] ` <20141203230551.GC8822-FZi0V3Vbi30CUdFEqe4BF2D2FQJk+8+b@public.gmane.org>
2014-12-04 0:54 ` Jesse Gross
2014-12-04 1:15 ` Thomas Graf
2014-12-04 1:51 ` Jesse Gross [this message]
2014-12-04 9:26 ` Thomas Graf
2014-12-04 23:19 ` Jesse Gross
2014-12-04 7:48 ` Du Fan
2014-12-04 23:23 ` Jesse Gross
2014-12-05 0:25 ` Du Fan
2014-12-03 2:31 ` Du, Fan
2015-01-05 6:02 ` Fan Du
[not found] ` <54AA2912.6090903-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-01-05 17:58 ` Jesse Gross
2015-01-06 9:34 ` Fan Du
2015-01-06 19:11 ` Jesse Gross
[not found] ` <CAEP_g=8bCR=PeSoi09jLWLtNUrxhzx45h1Wm=9D=R57AqUac2w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-07 5:58 ` Fan Du
2015-01-07 20:52 ` Jesse Gross
[not found] ` <CAEP_g=8EBeQUFkRRsG3sznYryd+LE9qJKWQXfS==HG2HDO=UKA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-08 9:39 ` Fan Du
2015-01-08 19:55 ` Jesse Gross
[not found] ` <CAEP_g=9hh+MG7AWEnct7CwRqp=ZghpbkDeQ5BhGQktDgMST1jA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-09 5:42 ` Fan Du
2015-01-12 18:48 ` Jesse Gross
2015-01-09 5:48 ` Fan Du
2015-01-12 18:55 ` Jesse Gross
2015-01-13 16:58 ` Thomas Graf
2014-12-02 15:44 ` Flavio Leitner
2014-12-02 18:06 ` Jesse Gross
2014-12-02 21:32 ` Flavio Leitner
2014-12-02 21:47 ` Jesse Gross
2014-12-03 1:58 ` Du, Fan
2014-11-30 10:26 ` Florian Westphal
2014-11-30 10:55 ` Du, Fan
2014-11-30 15:11 ` Florian Westphal
2014-12-01 6:47 ` Du, Fan
2014-12-03 3:23 ` David Miller
2014-12-03 3:32 ` Du, Fan
2014-12-03 4:35 ` David Miller
2014-12-03 4:50 ` Du, Fan
2014-12-03 5:14 ` David Miller
2014-12-03 6:53 ` Du, Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEP_g=8U_w+dxUHsTH2JQ9dGNHaJp-ai8pdmrfeYBin9NZ46jQ@mail.gmail.com' \
--to=jesse@nicira.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=fan.du@intel.com \
--cc=fw@strlen.de \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).