netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Andrii Nakryiko <andriin@fb.com>
Cc: Alexei Starovoitov <ast@fb.com>,
	Daniel Borkmann <daniel@iogearbox.net>, bpf <bpf@vger.kernel.org>,
	Networking <netdev@vger.kernel.org>, Yonghong Song <yhs@fb.com>,
	Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH v3 bpf-next 0/4] capture integers in BTF type info for map defs
Date: Wed, 3 Jul 2019 12:19:29 -0700	[thread overview]
Message-ID: <CAEf4BzZSxpDS7KNupKXz8d+RS0LSynK7ZMK-HqJoDBwzR1u0ew@mail.gmail.com> (raw)
In-Reply-To: <20190703190604.4173641-1-andriin@fb.com>

On Wed, Jul 3, 2019 at 12:06 PM Andrii Nakryiko <andriin@fb.com> wrote:
>
> This patch set implements an update to how BTF-defined maps are specified. The
> change is in how integer attributes, e.g., type, max_entries, map_flags, are
> specified: now they are captured as part of map definition struct's BTF type
> information (using array dimension), eliminating the need for compile-time
> data initialization and keeping all the metadata in one place.
>
> All existing selftests that were using BTF-defined maps are updated, along
> with some other selftests, that were switched to new syntax.
>
> v2->v3:
> - rename __int into __uint (Yonghong);
> v1->v2:
> - split bpf_helpers.h change from libbpf change (Song).
>
> Andrii Nakryiko (4):
>   libbpf: capture value in BTF type info for BTF-defined map defs
>   selftests/bpf: add __int and __type macro for BTF-defined maps
>   selftests/bpf: convert selftests using BTF-defined maps to new syntax
>   selftests/bpf: convert legacy BPF maps to BTF-defined ones


Forgot to add Song's:

Acked-by: Song Liu <songliubraving@fb.com>

Daniel, if there will be no more feedback, do you mind adding it
before landing? If not, I can submit new version with Acks added.

Thanks!

  parent reply	other threads:[~2019-07-03 19:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-03 19:06 [PATCH v3 bpf-next 0/4] capture integers in BTF type info for map defs Andrii Nakryiko
2019-07-03 19:06 ` [PATCH v3 bpf-next 1/4] libbpf: capture value in BTF type info for BTF-defined " Andrii Nakryiko
2019-07-03 19:06 ` [PATCH v3 bpf-next 2/4] selftests/bpf: add __int and __type macro for BTF-defined maps Andrii Nakryiko
2019-07-03 22:41   ` Yonghong Song
2019-07-03 19:06 ` [PATCH v3 bpf-next 3/4] selftests/bpf: convert selftests using BTF-defined maps to new syntax Andrii Nakryiko
2019-07-03 19:06 ` [PATCH v3 bpf-next 4/4] selftests/bpf: convert legacy BPF maps to BTF-defined ones Andrii Nakryiko
2019-07-03 19:19 ` Andrii Nakryiko [this message]
2019-07-03 22:42 ` [PATCH v3 bpf-next 0/4] capture integers in BTF type info for map defs Yonghong Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEf4BzZSxpDS7KNupKXz8d+RS0LSynK7ZMK-HqJoDBwzR1u0ew@mail.gmail.com \
    --to=andrii.nakryiko@gmail.com \
    --cc=andriin@fb.com \
    --cc=ast@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).