From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andriin@fb.com>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
Alan Maguire <alan.maguire@oracle.com>,
Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCHv2 bpf-next 0/7] bpf, x86: Add bpf_get_func_ip helper
Date: Wed, 7 Jul 2021 14:00:38 -0700 [thread overview]
Message-ID: <CAEf4BzZgqOwN5N+pLPriWRmOFSgBd4vgO-S69L1mO51P82FRdA@mail.gmail.com> (raw)
In-Reply-To: <YOYFZeY4U2wl/Ru5@krava>
On Wed, Jul 7, 2021 at 1:42 PM Jiri Olsa <jolsa@redhat.com> wrote:
>
> ugh forgot to cc Masami.. sorry, I can resend if needed
Can you please also add v2, v3, etc tags to *each patch*, not just
cover letter? It makes tracking different versions much easier.
Thanks!
>
> jirka
>
> On Wed, Jul 07, 2021 at 09:46:12PM +0200, Jiri Olsa wrote:
> > hi,
> > adding bpf_get_func_ip helper that returns IP address of the
> > caller function for trampoline and krobe programs.
> >
> > There're 2 specific implementation of the bpf_get_func_ip
> > helper, one for trampoline progs and one for kprobe/kretprobe
> > progs.
> >
> > The trampoline helper call is replaced/inlined by verifier
> > with simple move instruction. The kprobe/kretprobe is actual
> > helper call that returns prepared caller address.
> >
> > Also available at:
> > https://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
> > bpf/get_func_ip
> >
> > v2 changes:
> > - use kprobe_running to get kprobe instead of cpu var [Masami]
> > - added support to add kprobe on function+offset
> > and test for that [Alan]
> >
> > thanks,
> > jirka
> >
> >
> > ---
> > Alan Maguire (1):
> > libbpf: allow specification of "kprobe/function+offset"
> >
> > Jiri Olsa (6):
> > bpf, x86: Store caller's ip in trampoline stack
> > bpf: Enable BPF_TRAMP_F_IP_ARG for trampolines with call_get_func_ip
> > bpf: Add bpf_get_func_ip helper for tracing programs
> > bpf: Add bpf_get_func_ip helper for kprobe programs
> > selftests/bpf: Add test for bpf_get_func_ip helper
> > selftests/bpf: Add test for bpf_get_func_ip in kprobe+offset probe
> >
> > arch/x86/net/bpf_jit_comp.c | 19 +++++++++++++++++++
> > include/linux/bpf.h | 5 +++++
> > include/linux/filter.h | 3 ++-
> > include/uapi/linux/bpf.h | 7 +++++++
> > kernel/bpf/trampoline.c | 12 +++++++++---
> > kernel/bpf/verifier.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > kernel/trace/bpf_trace.c | 32 ++++++++++++++++++++++++++++++++
> > tools/include/uapi/linux/bpf.h | 7 +++++++
> > tools/lib/bpf/libbpf.c | 20 +++++++++++++++++---
> > tools/testing/selftests/bpf/prog_tests/get_func_ip_test.c | 42 ++++++++++++++++++++++++++++++++++++++++++
> > tools/testing/selftests/bpf/progs/get_func_ip_test.c | 75 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > 11 files changed, 270 insertions(+), 7 deletions(-)
> > create mode 100644 tools/testing/selftests/bpf/prog_tests/get_func_ip_test.c
> > create mode 100644 tools/testing/selftests/bpf/progs/get_func_ip_test.c
>
prev parent reply other threads:[~2021-07-07 21:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 19:46 [PATCHv2 bpf-next 0/7] bpf, x86: Add bpf_get_func_ip helper Jiri Olsa
2021-07-07 19:46 ` [PATCH 1/7] bpf, x86: Store caller's ip in trampoline stack Jiri Olsa
2021-07-07 19:46 ` [PATCH 2/7] bpf: Enable BPF_TRAMP_F_IP_ARG for trampolines with call_get_func_ip Jiri Olsa
2021-07-07 19:46 ` [PATCH 3/7] bpf: Add bpf_get_func_ip helper for tracing programs Jiri Olsa
2021-07-07 19:46 ` [PATCH 4/7] bpf: Add bpf_get_func_ip helper for kprobe programs Jiri Olsa
2021-07-07 19:46 ` [PATCH 5/7] selftests/bpf: Add test for bpf_get_func_ip helper Jiri Olsa
2021-07-07 19:46 ` [PATCH 6/7] libbpf: allow specification of "kprobe/function+offset" Jiri Olsa
2021-07-07 19:46 ` [PATCH 7/7] selftests/bpf: Add test for bpf_get_func_ip in kprobe+offset probe Jiri Olsa
2021-07-07 19:49 ` [PATCHv2 bpf-next 0/7] bpf, x86: Add bpf_get_func_ip helper Jiri Olsa
2021-07-07 21:00 ` Andrii Nakryiko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzZgqOwN5N+pLPriWRmOFSgBd4vgO-S69L1mO51P82FRdA@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=alan.maguire@oracle.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=jolsa@redhat.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).