From: Craig Gallek <kraigatgoog@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Eric Dumazet <edumazet@google.com>,
Alexander Potapenko <glider@google.com>,
David Miller <davem@davemloft.net>,
Networking <netdev@vger.kernel.org>
Subject: Re: Uninitialized value in __sk_nulls_add_node_rcu()
Date: Tue, 5 Dec 2017 14:39:04 -0500 [thread overview]
Message-ID: <CAEfhGiwQe-whM8p1OuLC3WntogmC6AeLS0HPRUcTL85ii8hKmw@mail.gmail.com> (raw)
On Tue, Dec 5, 2017 at 9:18 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Tue, 2017-12-05 at 06:15 -0800, Eric Dumazet wrote:
>>
>> + hlist_nulls_add_head_rcu(&sk->sk_nulss_node, list);
>
> Typo here, this needs sk_nulls_node of course.
>
Thanks Eric, this looks good to me. The tail insertion is still
required in udp_lib_get_port for the second layer hash, but not here.
fwiw, reuseport_dualstack in the selftests directory verifies this
behavior. I tried it with your patch (it still passes) and removing
the udp_lib_get_port path (to make sure it breaks when it should).
Craig
next reply other threads:[~2017-12-05 19:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 19:39 Craig Gallek [this message]
2017-12-05 20:07 ` Uninitialized value in __sk_nulls_add_node_rcu() Eric Dumazet
-- strict thread matches above, loose matches on Subject: below --
2017-12-05 20:11 Craig Gallek
2017-10-26 12:51 Alexander Potapenko
2017-10-26 14:20 ` Alexander Potapenko
2017-10-26 14:47 ` Eric Dumazet
2017-10-26 14:52 ` Eric Dumazet
2017-10-26 14:56 ` Alexander Potapenko
2017-11-22 13:38 ` Alexander Potapenko
2017-11-22 15:58 ` Eric Dumazet
2017-12-05 14:15 ` Eric Dumazet
2017-12-05 14:18 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEfhGiwQe-whM8p1OuLC3WntogmC6AeLS0HPRUcTL85ii8hKmw@mail.gmail.com \
--to=kraigatgoog@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=glider@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).