Re: [PATCH iproute2] pedit action: add mask for changing bits.

["Anton 'EvilMan' Danilov" <littlesmilingcloud@gmail.com>]

Hi, Jamal.

2012/2/27 jamal <hadi@cyberus.ca>:
>
> Looks like a reasonable feature to have - but it has to continue working
> as before for things that dont need the mask.
>
>>
>> diff --git a/tc/m_pedit.c b/tc/m_pedit.c
>> index 7499846..f081eff 100644
>> --- a/tc/m_pedit.c
>> +++ b/tc/m_pedit.c
>
>>
>>       tkey->val = htonl(tkey->val & retain);
>> -     tkey->mask = htonl(tkey->mask | ~retain);
>> +     tkey->mask = htonl(~tkey->mask | ~retain);
>
> A change like the above worries me that this may work for your use case
> but will break other things that used to work. I'd like to run some
> tests but dont have the cycles for the next few days. Alternatively, I
> could explain some tests to you and you could validate and fix whatever
> breaks.
> Let me know what is best for you.
>

Can You explain tests to me? I'll check behavior with my changes and fix breaks


-- 
Anton.