From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Subject: Re: [PATCH iproute2] vxlan: allow specifying multiple default destinations Date: Wed, 29 May 2013 13:52:55 +0300 Message-ID: References: <1369821617-29098-1-git-send-email-mike.rapoport@ravellosystems.com> <1369821617-29098-4-git-send-email-mike.rapoport@ravellosystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: netdev@vger.kernel.org To: Cong Wang Return-path: Received: from na3sys010aog105.obsmtp.com ([74.125.245.78]:58336 "HELO na3sys010aog105.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S965467Ab3E2Kw5 (ORCPT ); Wed, 29 May 2013 06:52:57 -0400 Received: by mail-qc0-f172.google.com with SMTP id z1so4672002qcx.31 for ; Wed, 29 May 2013 03:52:56 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, May 29, 2013 at 1:13 PM, Cong Wang wrote: > On Wed, 29 May 2013 at 10:00 GMT, Mike Rapoport wrote: >> Signed-off-by: Mike Rapoport >> --- >> ip/iplink_vxlan.c | 125 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 125 insertions(+) >> >> diff --git a/ip/iplink_vxlan.c b/ip/iplink_vxlan.c >> index 1025326..be6c0ac 100644 >> --- a/ip/iplink_vxlan.c >> +++ b/ip/iplink_vxlan.c >> @@ -28,11 +28,87 @@ static void explain(void) >> fprintf(stderr, " [ port MIN MAX ] [ [no]learning ]\n"); >> fprintf(stderr, " [ [no]proxy ] [ [no]rsc ]\n"); >> fprintf(stderr, " [ [no]l2miss ] [ [no]l3miss ]\n"); >> + fprintf(stderr, " [ dstadd DST ]\n"); >> + fprintf(stderr, " [ dstdel ADDR ]\n"); > > Excuse me, but this looks like a design failure as you manipulate > remotes with `ip link` while creating vxlan devices, shouldn't this be > in a standard alone tool if we can't reuse any existing tool? Or am I > missing anything? Frankly, I had a long hesitation about the userspace implementation. >>From one side it seems very logical to use ip/iplink_vxlan for vxlan device manipulations. Moreover, since the remotes are used pretty much the same way as the group address, adding the remotes management to ip/iplink_vxlan makes a lot of sense. Besides, creation of stand alone tool for remote list manipulation in vxlan seemed to me little bit far fetched. On the other hand, I quite agree with you that ip link add vxlan0 ... dstadd 192.168.1.1 or ip link set vxlan0 ... dstdel 192.168.1.1 looks weird at least. > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Sincerely yours, Mike.