From: Mahesh Bandewar <maheshb@google.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Jay Vosburgh <j.vosburgh@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Veaceslav Falico <vfalico@gmail.com>,
Nikolay Aleksandrov <nikolay@redhat.com>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH next 5/6] bonding: Allow userspace to set macaddr on bonding-dev
Date: Sat, 7 Feb 2015 19:32:57 -0800 [thread overview]
Message-ID: <CAF2d9jgi11=FHEZVkdOZ3EKBAMa7pL6NLroy=Dtr-+68B8Tdcg@mail.gmail.com> (raw)
In-Reply-To: <20150207142652.708bd66e@urahara>
On Sat, Feb 7, 2015 at 2:26 PM, Stephen Hemminger
<stephen@networkplumber.org> wrote:
> On Fri, 6 Feb 2015 16:51:56 -0800
> Mahesh Bandewar <maheshb@google.com> wrote:
>
>> @@ -396,6 +398,13 @@ static const struct bond_option bond_opts[BOND_OPT_LAST] = {
>> .values = bond_ad_actor_sysprio_tbl,
>> .set = bond_option_ad_actor_sysprio_set,
>> },
>> + [BOND_OPT_AD_ACTOR_SYS_MACADDR] = {
>> + .id = BOND_OPT_AD_ACTOR_SYS_MACADDR,
>> + .name = "ad_actor_system_mac_address",
>> + .unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_8023AD)),
>> + .flags = BOND_OPTFLAG_RAWVAL | BOND_OPTFLAG_IFDOWN,
>> + .set = bond_option_ad_actor_sys_macaddr_set,
>> + },
>> };
>
> I would consider the module command line options deprecated
> at this point. Why add more?
These are not the module parameters.
prev parent reply other threads:[~2015-02-08 3:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-07 0:51 [PATCH next 5/6] bonding: Allow userspace to set macaddr on bonding-dev Mahesh Bandewar
2015-02-07 1:20 ` Jay Vosburgh
2015-02-07 1:22 ` Maciej Żenczykowski
2015-02-07 1:35 ` Mahesh Bandewar
2015-02-07 1:54 ` Jay Vosburgh
2015-02-07 2:41 ` Mahesh Bandewar
2015-02-07 3:22 ` Andy Gospodarek
2015-02-07 3:31 ` Andy Gospodarek
2015-02-07 6:49 ` Jay Vosburgh
2015-02-07 7:11 ` Maciej Żenczykowski
2015-02-07 19:15 ` Mahesh Bandewar
2015-02-07 22:26 ` Stephen Hemminger
2015-02-08 3:32 ` Mahesh Bandewar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF2d9jgi11=FHEZVkdOZ3EKBAMa7pL6NLroy=Dtr-+68B8Tdcg@mail.gmail.com' \
--to=maheshb@google.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.vosburgh@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=stephen@networkplumber.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).