From mboxrd@z Thu Jan 1 00:00:00 1970 From: Willem de Bruijn Subject: Re: [PATCH net-next] packet: fix panic in __packet_set_timestamp on tpacket_v3 in tx mode Date: Mon, 6 Mar 2017 12:45:58 -0500 Message-ID: References: <1483580068-13854-1-git-send-email-daniel@iogearbox.net> <1483640872.9712.1.camel@edumazet-glaptop3.roam.corp.google.com> <586E9A0F.1020002@iogearbox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Daniel Borkmann , Eric Dumazet , David Miller , Sowmini Varadhan , Willem de Bruijn , netdev To: chetan loke Return-path: Received: from mail-wr0-f172.google.com ([209.85.128.172]:34980 "EHLO mail-wr0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753986AbdCFSOT (ORCPT ); Mon, 6 Mar 2017 13:14:19 -0500 Received: by mail-wr0-f172.google.com with SMTP id g10so122655051wrg.2 for ; Mon, 06 Mar 2017 10:14:18 -0800 (PST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Mar 6, 2017 at 12:13 PM, chetan loke wrote: >>> >>> Gosh. Can we also replace this BUG() into something less aggressive ? >> >> >> There are currently 5 of these WARN() + BUG() constructs and 1 BUG()-only >> for the 'default' TPACKET version spread all over af_packet, so probably >> makes sense to rather make all of them less aggressive. >> >> > > Very few consumers actually go looking in the kernel logs to see the > error-warnings and report them back here. > > This severity will get them to report the incident which in this case > got fixed?? But BUG_ONs in the datapath can cause outages in real production environments. This should not happen for recoverable failures. For users who cannot be bothered to check their logs, there is sysctl kernel.panic_on_warn.