From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Alan Maguire <alan.maguire@oracle.com>
Cc: Network Development <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Stanislav Fomichev <sdf@google.com>,
Peter Oskolkov <posk@google.com>,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH bpf-next 08/13] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_FIXED_GSO
Date: Thu, 21 Mar 2019 10:00:48 -0400 [thread overview]
Message-ID: <CAF=yD-KB-cDqNngXOdrrrton2GVky5VDocsFDVgB+3AtcymxNQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.LRH.2.20.1903211342330.11532@dhcp-10-175-164-135.vpn.oracle.com>
On Thu, Mar 21, 2019 at 9:43 AM Alan Maguire <alan.maguire@oracle.com> wrote:
>
>
>
> On Wed, 20 Mar 2019, Willem de Bruijn wrote:
>
> > From: Willem de Bruijn <willemb@google.com>
> >
> > bpf_skb_adjust_room adjusts gso_size of gso packets to account for the
> > pushed or popped header room.
> >
> > This is not allowed with UDP, where gso_size delineates datagrams. Add
> > an option to avoid these updates and allow this call for datagrams.
> >
> > It can also be used with TCP, when MSS is known to allow headroom,
> > e.g., through MSS clamping or route MTU.
> >
> > Link: https://patchwork.ozlabs.org/patch/1052497/
> > Signed-off-by: Willem de Bruijn <willemb@google.com>
> > ---
> > include/uapi/linux/bpf.h | 4 ++++
> > net/core/filter.c | 36 +++++++++++++++++++++++++-----------
> > 2 files changed, 29 insertions(+), 11 deletions(-)
> >
> > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> > index 4f5c918e6fcf4..0eda8f564a381 100644
> > --- a/include/uapi/linux/bpf.h
> > +++ b/include/uapi/linux/bpf.h
> > @@ -2593,6 +2593,10 @@ enum bpf_func_id {
> > /* Current network namespace */
> > #define BPF_F_CURRENT_NETNS (-1L)
> >
> > +/* BPF_FUNC_skb_adjust_room flags. */
> > +#define BPF_F_ADJ_ROOM_FIXED_GSO (1ULL << 0)
>
> minor nit - could we add this flag to the documentation for
> bpf_skb_adjust_room? Same suggestion for the encap flags in
> patch 8 too. Thanks!
>
> Reviewed-by: Alan Maguire <alan.maguire@oracle.com>
Definitely, will do in v2. Thanks.
next prev parent reply other threads:[~2019-03-21 14:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 14:49 [PATCH bpf-next 00/13] bpf tc tunneling Willem de Bruijn
2019-03-20 14:49 ` [PATCH bpf-next 01/13] bpf: in bpf_skb_adjust_room avoid copy in tx fast path Willem de Bruijn
2019-03-20 14:49 ` [PATCH bpf-next 02/13] selftests/bpf: bpf tunnel encap test Willem de Bruijn
2019-03-20 14:49 ` [PATCH bpf-next 03/13] selftests/bpf: expand bpf tunnel test with decap Willem de Bruijn
2019-03-20 14:49 ` [PATCH bpf-next 04/13] selftests/bpf: expand bpf tunnel test to ipv6 Willem de Bruijn
2019-03-20 14:49 ` [PATCH bpf-next 05/13] selftests/bpf: extend bpf tunnel test with gre Willem de Bruijn
2019-03-20 14:49 ` [PATCH bpf-next 06/13] selftests/bpf: extend bpf tunnel test with tso Willem de Bruijn
2019-03-20 14:49 ` [PATCH bpf-next 07/13] bpf: add bpf_skb_adjust_room mode BPF_ADJ_ROOM_MAC Willem de Bruijn
2019-03-20 14:49 ` [PATCH bpf-next 08/13] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_FIXED_GSO Willem de Bruijn
2019-03-21 13:42 ` Alan Maguire
2019-03-21 14:00 ` Willem de Bruijn [this message]
2019-03-20 14:49 ` [PATCH bpf-next 09/13] bpf: add bpf_skb_adjust_room encap flags Willem de Bruijn
2019-03-20 15:51 ` Alan Maguire
2019-03-20 18:10 ` Willem de Bruijn
2019-03-21 3:13 ` Alexei Starovoitov
2019-03-21 13:25 ` Willem de Bruijn
2019-03-20 14:49 ` [PATCH bpf-next 10/13] bpf: Sync bpf.h to tools Willem de Bruijn
2019-03-20 14:56 ` Soheil Hassas Yeganeh
2019-03-20 14:49 ` [PATCH bpf-next 11/13] selftests/bpf: convert bpf tunnel test to BPF_ADJ_ROOM_MAC Willem de Bruijn
2019-03-20 14:49 ` [PATCH bpf-next 12/13] selftests/bpf: convert bpf tunnel test to BPF_F_ADJ_ROOM_FIXED_GSO Willem de Bruijn
2019-03-20 14:49 ` [PATCH bpf-next 13/13] selftests/bpf: convert bpf tunnel test to encap modes Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF=yD-KB-cDqNngXOdrrrton2GVky5VDocsFDVgB+3AtcymxNQ@mail.gmail.com' \
--to=willemdebruijn.kernel@gmail.com \
--cc=alan.maguire@oracle.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=posk@google.com \
--cc=sdf@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).